* [PATCH] rtc: at91sam9: remove duplicate assignment of variable mr
@ 2016-03-28 11:24 Colin King
2016-03-28 22:11 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-03-28 11:24 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, rtc-linux; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
mr is written twice with the same value, remove one of the
redundant assignments to mr.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/rtc/rtc-at91sam9.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
index 7206e2f..99732e6 100644
--- a/drivers/rtc/rtc-at91sam9.c
+++ b/drivers/rtc/rtc-at91sam9.c
@@ -268,7 +268,7 @@ static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
static int at91_rtc_proc(struct device *dev, struct seq_file *seq)
{
struct sam9_rtc *rtc = dev_get_drvdata(dev);
- u32 mr = mr = rtt_readl(rtc, MR);
+ u32 mr = rtt_readl(rtc, MR);
seq_printf(seq, "update_IRQ\t: %s\n",
(mr & AT91_RTT_RTTINCIEN) ? "yes" : "no");
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: at91sam9: remove duplicate assignment of variable mr
2016-03-28 11:24 [PATCH] rtc: at91sam9: remove duplicate assignment of variable mr Colin King
@ 2016-03-28 22:11 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2016-03-28 22:11 UTC (permalink / raw)
To: Colin King; +Cc: Alessandro Zummo, rtc-linux, linux-kernel
On 28/03/2016 at 12:24:00 +0100, Colin King wrote :
> From: Colin Ian King <colin.king@canonical.com>
>
> mr is written twice with the same value, remove one of the
> redundant assignments to mr.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/rtc/rtc-at91sam9.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-28 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-28 11:24 [PATCH] rtc: at91sam9: remove duplicate assignment of variable mr Colin King
2016-03-28 22:11 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®