mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Manav Batra <batmanav10@gmail.com>
Cc: bhaktipriya96@gmail.com, dilekuzulmez@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes some checkpatch.pl warnings
Date: Wed, 6 Apr 2016 13:56:05 -0700	[thread overview]
Message-ID: <20160406205605.GB13901@kroah.com> (raw)
In-Reply-To: <20160406113807.GA19489@iiitd.ac.in>

On Wed, Apr 06, 2016 at 04:38:07AM -0700, Manav Batra wrote:
> CHECK: Alignment should match open parenthesis
> WARNING: line over 80 characters
> 
> Signed-off-by: Manav Batra <batmanav10@gmail.com>
> ---
>  drivers/staging/rts5208/ms.c | 66 ++++++++++++++++++++++++++------------------
>  1 file changed, 39 insertions(+), 27 deletions(-)

Your subject is a bit "odd", please have it match the format that other
patches that have been accepted for this driver follows...

Also only do one thing per patch, you did multiple different things
here.

thanks,

greg k-h

      reply	other threads:[~2016-04-06 20:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 11:38 Manav Batra
2016-04-06 20:56 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406205605.GB13901@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=batmanav10@gmail.com \
    --cc=bhaktipriya96@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dilekuzulmez@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®