Re: [RFC PATCH v2 0/3] Add ACPI support for pinctrl configuration

[Mika Westerberg <mika.westerberg@linux.intel.com>]

On Tue, Apr 05, 2016 at 06:33:23PM +0300, Irina Tirdea wrote:
> This is a proposal for adding ACPI support for pin controller
> configuration.
> 
> It has been developed to enable the MinnowBoard and IoT community
> by providing an easy way to specify pin multiplexing and
> pin configuration.
> 
> This proposal is based on using _DSD properties to specify device
> states and configuration nodes and it follows closely the device
> tree model. Device states are defined using the Device Properties
> format and the configuration nodes are defined using the
> Hierarchical Properties Extension format. The generic properties
> for the configuration nodes are the same as the ones for device
> tree, while pincontroller drivers can also define custom ones.
> 
> Changes from v1:
>  - address code review comments regarding coding style, documentation
> and fixes
>  - rewrote patch 3 ("pinctrl: Parse GpioInt/GpioIo resources") to
> avoid using triple pointers
>  - define pinconf_generic_dt_node_to_map since it is used by pinctrl
> sirf driver
>  - add dependency on PINCONF_GENERIC to the entire ACPI parsing code
>  - dropped first patch from the series since it got merged
> ("pinctrl: Rename pinctrl_utils_dt_free_map to pinctrl_utils_free_map")
> 
> Irina Tirdea (3):
>   pinctrl: pinconf-generic: Add ACPI support
>   pinctrl: Add ACPI support
>   pinctrl: Parse GpioInt/GpioIo resources

The series looks good to me now,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Of course this all depends on the decision whether this is the preferred
way of controlling and muxing pins in ACPI.