mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86:sysfb_efi:efifb_set_system: fix miss valid address range in later BARs
@ 2016-04-11  3:22 Wang YanQing
  0 siblings, 0 replies; only message in thread
From: Wang YanQing @ 2016-04-11  3:22 UTC (permalink / raw)
  To: tomi.valkeinen; +Cc: pjones, dh.herrmann, hpa, linux-kernel, x86

We can't just break out when meet start is equal to zero,
this will cause we miss valid address range in later BARs.

On the other hand, it isn't enough to test start only
for below situation:
0(start) <= lfb_base < end

Signed-off-by: Wang YanQing <udknight@gmail.com>
---
 arch/x86/kernel/sysfb_efi.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/sysfb_efi.c b/arch/x86/kernel/sysfb_efi.c
index b285d4e..ac0b521 100644
--- a/arch/x86/kernel/sysfb_efi.c
+++ b/arch/x86/kernel/sysfb_efi.c
@@ -106,10 +106,19 @@ static int __init efifb_set_system(const struct dmi_system_id *id)
 					continue;
 				for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
 					resource_size_t start, end;
+					unsigned long flags;
+
+					flags = pci_resource_flags(dev, i);
+					if (!(flags & IORESOURCE_MEM))
+						continue;
+
+					if (flags & IORESOURCE_UNSET)
+						continue;
+
+					if (pci_resource_len(dev, i) == 0)
+						continue;
 
 					start = pci_resource_start(dev, i);
-					if (start == 0)
-						break;
 					end = pci_resource_end(dev, i);
 					if (screen_info.lfb_base >= start &&
 					    screen_info.lfb_base < end) {
-- 
1.8.5.6.2.g3d8a54e.dirty

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-10 19:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-11  3:22 [PATCH] x86:sysfb_efi:efifb_set_system: fix miss valid address range in later BARs Wang YanQing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®