From: David Miller <davem@davemloft.net>
To: lars.persson@axis.com
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
linux-kernel@vger.kernel.org, xiyou.wangcong@gmail.com,
eric.dumazet@gmail.com, larper@axis.com
Subject: Re: [PATCH net v3] net: sched: do not requeue a NULL skb
Date: Thu, 14 Apr 2016 01:29:30 -0400 (EDT) [thread overview]
Message-ID: <20160414.012930.746981483324064373.davem@davemloft.net> (raw)
In-Reply-To: <1460443552-26710-1-git-send-email-larper@axis.com>
From: Lars Persson <lars.persson@axis.com>
Date: Tue, 12 Apr 2016 08:45:52 +0200
> A failure in validate_xmit_skb_list() triggered an unconditional call
> to dev_requeue_skb with skb=NULL. This slowly grows the queue
> discipline's qlen count until all traffic through the queue stops.
>
> We take the optimistic approach and continue running the queue after a
> failure since it is unknown if later packets also will fail in the
> validate path.
>
> Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock")
> Signed-off-by: Lars Persson <larper@axis.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-04-14 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 6:45 Lars Persson
2016-04-12 16:23 ` Eric Dumazet
2016-04-14 5:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414.012930.746981483324064373.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=larper@axis.com \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®