From: Ira Weiny <ira.weiny@intel.com>
To: "Markus Böhme" <markus.boehme@mailbox.org>
Cc: devel@driverdev.osuosl.org,
Mike Marciniszyn <infinipath@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/rdma/hfi1: select CRC32
Date: Thu, 14 Apr 2016 13:59:22 -0400 [thread overview]
Message-ID: <20160414175922.GB11641@rhel.sc.intel.com> (raw)
In-Reply-To: <1459465467-31367-1-git-send-email-markus.boehme@mailbox.org>
On Fri, Apr 01, 2016 at 01:04:05AM +0200, Markus Böhme wrote:
> The function parse_platform_config in firmware.c calls crc32_le.
> Building without CRC32 selected causes a link error:
>
> drivers/built-in.o: In function `parse_platform_config':
> (.text+0x92ffa): undefined reference to `crc32_le'
>
> Signed-off-by: Markus Böhme <markus.boehme@mailbox.org>
Doug did you pick this up?
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/staging/rdma/hfi1/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig
> index 3e668d8..a925fb0 100644
> --- a/drivers/staging/rdma/hfi1/Kconfig
> +++ b/drivers/staging/rdma/hfi1/Kconfig
> @@ -2,6 +2,7 @@ config INFINIBAND_HFI1
> tristate "Intel OPA Gen1 support"
> depends on X86_64 && INFINIBAND_RDMAVT
> select MMU_NOTIFIER
> + select CRC32
> default m
> ---help---
> This is a low-level driver for Intel OPA Gen1 adapter.
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-04-14 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 23:04 Markus Böhme
2016-04-14 17:59 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414175922.GB11641@rhel.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markus.boehme@mailbox.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®