* [PATCH] staging/rdma/hfi1: select CRC32
@ 2016-03-31 23:04 Markus Böhme
2016-04-14 17:59 ` Ira Weiny
0 siblings, 1 reply; 2+ messages in thread
From: Markus Böhme @ 2016-03-31 23:04 UTC (permalink / raw)
To: devel
Cc: Markus Böhme, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock, Greg Kroah-Hartman, linux-rdma, linux-kernel
The function parse_platform_config in firmware.c calls crc32_le.
Building without CRC32 selected causes a link error:
drivers/built-in.o: In function `parse_platform_config':
(.text+0x92ffa): undefined reference to `crc32_le'
Signed-off-by: Markus Böhme <markus.boehme@mailbox.org>
---
drivers/staging/rdma/hfi1/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig
index 3e668d8..a925fb0 100644
--- a/drivers/staging/rdma/hfi1/Kconfig
+++ b/drivers/staging/rdma/hfi1/Kconfig
@@ -2,6 +2,7 @@ config INFINIBAND_HFI1
tristate "Intel OPA Gen1 support"
depends on X86_64 && INFINIBAND_RDMAVT
select MMU_NOTIFIER
+ select CRC32
default m
---help---
This is a low-level driver for Intel OPA Gen1 adapter.
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging/rdma/hfi1: select CRC32
2016-03-31 23:04 [PATCH] staging/rdma/hfi1: select CRC32 Markus Böhme
@ 2016-04-14 17:59 ` Ira Weiny
0 siblings, 0 replies; 2+ messages in thread
From: Ira Weiny @ 2016-04-14 17:59 UTC (permalink / raw)
To: Markus Böhme
Cc: devel, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock, Greg Kroah-Hartman, linux-rdma, linux-kernel
On Fri, Apr 01, 2016 at 01:04:05AM +0200, Markus Böhme wrote:
> The function parse_platform_config in firmware.c calls crc32_le.
> Building without CRC32 selected causes a link error:
>
> drivers/built-in.o: In function `parse_platform_config':
> (.text+0x92ffa): undefined reference to `crc32_le'
>
> Signed-off-by: Markus Böhme <markus.boehme@mailbox.org>
Doug did you pick this up?
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/staging/rdma/hfi1/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig
> index 3e668d8..a925fb0 100644
> --- a/drivers/staging/rdma/hfi1/Kconfig
> +++ b/drivers/staging/rdma/hfi1/Kconfig
> @@ -2,6 +2,7 @@ config INFINIBAND_HFI1
> tristate "Intel OPA Gen1 support"
> depends on X86_64 && INFINIBAND_RDMAVT
> select MMU_NOTIFIER
> + select CRC32
> default m
> ---help---
> This is a low-level driver for Intel OPA Gen1 adapter.
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-14 17:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-31 23:04 [PATCH] staging/rdma/hfi1: select CRC32 Markus Böhme
2016-04-14 17:59 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®