* [PATCH] net: tsi108: use NULL for pointer-typed argument
@ 2016-04-23 9:07 Julia Lawall
2016-04-26 5:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2016-04-23 9:07 UTC (permalink / raw)
To: netdev; +Cc: kernel-janitors, linux-kernel
The first argument of pci_free_consistent has type struct pci_dev *, so use
NULL instead of 0.
The semantic patch that performs this transformation is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
@@
pci_free_consistent(
- 0
+ NULL
, ...)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/tundra/tsi108_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -u -p a/drivers/net/ethernet/tundra/tsi108_eth.c b/drivers/net/ethernet/tundra/tsi108_eth.c
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1314,7 +1314,8 @@ static int tsi108_open(struct net_device
data->txring = dma_zalloc_coherent(NULL, txring_size, &data->txdma,
GFP_KERNEL);
if (!data->txring) {
- pci_free_consistent(0, rxring_size, data->rxring, data->rxdma);
+ pci_free_consistent(NULL, rxring_size, data->rxring,
+ data->rxdma);
return -ENOMEM;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: tsi108: use NULL for pointer-typed argument
2016-04-23 9:07 [PATCH] net: tsi108: use NULL for pointer-typed argument Julia Lawall
@ 2016-04-26 5:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-04-26 5:11 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sat, 23 Apr 2016 11:07:02 +0200
> The first argument of pci_free_consistent has type struct pci_dev *, so use
> NULL instead of 0.
>
> The semantic patch that performs this transformation is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> @@
> pci_free_consistent(
> - 0
> + NULL
> , ...)
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-26 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-23 9:07 [PATCH] net: tsi108: use NULL for pointer-typed argument Julia Lawall
2016-04-26 5:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®