* [PATCH]sched: cpuidle: Do not fetch current cpu in loop in idle thread
@ 2016-04-27 9:54 Gaurav Jindal (Gaurav Jindal)
0 siblings, 0 replies; only message in thread
From: Gaurav Jindal (Gaurav Jindal) @ 2016-04-27 9:54 UTC (permalink / raw)
To: mingo, peterz; +Cc: linux-kernel
Currently in idle thread loop, smp_processor_id() fetches the cpu id
every time it runs thus taking more cpu cycles.
Instead, save the cpu id as local varaible while entering the idle
thread and use it in the loop. Since it is local variable, it will be
correct for each core. It will also save cycles consumed while fetching cpu
id using smp_proceesor_id() in loop.
Patch:
------------------------------------------------------------------------------
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index 1214f0a..9696f9e 100644
--- a/kernel/sched/idle.c
+++ b/kernel/sched/idle.c
@@ -185,6 +185,9 @@ exit_idle:
*/
static void cpu_idle_loop(void)
{
+ int cpu_id;
+
+ cpu_id = smp_processor_id();
while(1) {
/*
*If the arch has a polling bit, we maintain an invariant:
@@ -202,7 +205,7 @@ static void cpu_idle_loop(void)
check_pgt_cache();
rmb();
- if (cpu_is_offline(smp_processor_id()))
+ if(cpu_is_offline(cpu_id))
arch_cpu_idle_dead();
local_irq_disable();
------------------------------------------------------------------------------
Signed-off-by: Gaurav Jindal<gaurav.jindal@spreadtrum.com>
Regards
Gaurav Jindal
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-04-27 9:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-27 9:54 [PATCH]sched: cpuidle: Do not fetch current cpu in loop in idle thread Gaurav Jindal (Gaurav Jindal)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®