mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	"Elliott, Robert (Persistent Memory)" <elliott@hpe.com>,
	Julius Werner <jwerner@chromium.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive
Date: Wed, 27 Apr 2016 17:09:13 +0200	[thread overview]
Message-ID: <20160427150913.m2vvhtriq27u65tk@ws.net.home> (raw)
In-Reply-To: <CAMHSBOW7MBtpVPZdt8yGggUhxk_ca3U+w9Wc-vg5fX7G-jB6mQ@mail.gmail.com>

On Tue, Apr 26, 2016 at 02:51:01PM -0700, Gwendal Grignou wrote:
> Julius and I were looking at the code when we spotted the issue.
> 
> As Julius said, "just pass a boot param", is not easy on certain
> machines, like phone. It is not user friendly either.
> The system won't boot at all, a typical user will have to do a full
> reinstall to fix the error.

And how typical user will fix the problem with corrupted primary
header after successful boot? I mean, use alternative header (without
force_gpt) is a good idea if we know that user will not ignore the
problem. The current solution is to force user to do anything.

It would be nice to have support for this issue in userspace 
and switch for example to single user mode, or so...

I'm also have doubts that printk() is the best way how to report 
this issue to userspace if we want to trigger any action :-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  reply	other threads:[~2016-04-27 15:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  1:06 Julius Werner
2016-04-26 10:20 ` Karel Zak
2016-04-26 18:33   ` Davidlohr Bueso
2016-04-26 20:13     ` Julius Werner
2016-04-26 20:34     ` Elliott, Robert (Persistent Memory)
2016-04-26 21:15       ` Davidlohr Bueso
2016-04-26 21:51         ` Gwendal Grignou
2016-04-27 15:09           ` Karel Zak [this message]
2016-04-27 15:45             ` Doug Anderson
2016-04-27 21:44             ` Julius Werner
2016-04-27  6:00       ` Ard Biesheuvel
2016-04-27 12:59         ` Austin S. Hemmelgarn
2016-04-26 14:38 ` Austin S. Hemmelgarn
2016-04-26 18:10   ` Davidlohr Bueso
2016-04-26 19:27     ` Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427150913.m2vvhtriq27u65tk@ws.net.home \
    --to=kzak@redhat.com \
    --cc=dave@stgolabs.net \
    --cc=dianders@chromium.org \
    --cc=elliott@hpe.com \
    --cc=gwendal@chromium.org \
    --cc=jwerner@chromium.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®