mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot
Date: Wed, 27 Apr 2016 16:12:19 +0100	[thread overview]
Message-ID: <20160427151219.GV3217@sirena.org.uk> (raw)
In-Reply-To: <1461765568-15828-4-git-send-email-hdegoede@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

On Wed, Apr 27, 2016 at 03:59:28PM +0200, Hans de Goede wrote:
> The maximum supported voltage for ldo_io# is 3.3V, but on cold
> boot the selector comes up at 0x1f, which maps to 3.8V.

Why not just implement that?  We know what it does and it preserves the
expected behaviour where we don't touch the regualtor unless explicitly
told it's OK.  We'll only ever try to set that value if the machine
explicitly gives permission for it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-04-27 15:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 13:59 [PATCH v2 resend 0/3] regulator: axp20x: 3 bugfixes Hans de Goede
2016-04-27 13:59 ` [PATCH v2 1/3] regulator: axp20x: Fix axp209 ldo4 ranges Hans de Goede
2016-04-27 13:59 ` [PATCH v2 2/3] regulator: axp20x: Fix axp22x ldo_io voltage ranges Hans de Goede
2016-04-27 16:35   ` Applied "regulator: axp20x: Fix axp22x ldo_io voltage ranges" to the regulator tree Mark Brown
2016-04-27 16:35   ` Mark Brown
2016-04-27 13:59 ` [PATCH v2 3/3] regulator: axp20x: Fix axp22x ldo_io registration error on cold boot Hans de Goede
2016-04-27 15:12   ` Mark Brown [this message]
2016-04-27 15:35     ` Hans de Goede
2016-04-27 15:48       ` Mark Brown
2016-04-27 16:04         ` Hans de Goede
2016-04-27 16:30           ` Mark Brown
2016-04-27 18:35             ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427151219.GV3217@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®