From: Andrew Morton <akpm@linux-foundation.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>,
Brian Norris <computersforpeace@gmail.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Rusty Russell <rusty@rustcorp.com.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] modpost: fix module autoloading for OF devices with generic compatible property
Date: Mon, 2 May 2016 14:53:20 -0700 [thread overview]
Message-ID: <20160502145320.f4529b37b32c9ec0a9fc96e1@linux-foundation.org> (raw)
In-Reply-To: <1462203339-15340-1-git-send-email-p.zabel@pengutronix.de>
On Mon, 2 May 2016 17:35:39 +0200 Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Since the wildcard at the end of OF module aliases is gone, autoloading
> of modules that don't match a device's last (most generic) compatible value
> fails.
>
> For example the CODA960 VPU on i.MX6Q has the SoC specific compatible
> "fsl,imx6q-vpu" and the generic compatible "cnm,coda960". Since the driver
> currently only works with knowledge about the SoC specific integration,
> it doesn't list "cnm,cod960" in the module device table.
> This results in the device compatible
> "of:NvpuT<NULL>Cfsl,imx6q-vpuCcnm,coda960" not matching the module alias
> "of:N*T*Cfsl,imx6q-vpu" anymore, whereas before commit 2f632369ab79
> ("modpost: don't add a trailing wildcard for OF module aliases") it
> matched the module alias "of:N*T*Cfsl,imx6q-vpu*".
>
> This patch adds two module aliases for each compatible, one without the
> wildcard and one with "C*" appended.
>
> $ modinfo coda | grep imx6q
> alias: of:N*T*Cfsl,imx6q-vpuC*
> alias: of:N*T*Cfsl,imx6q-vpu
I added this:
Cc: <stable@vger.kernel.org> [4.5+]
prev parent reply other threads:[~2016-05-02 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 15:35 Philipp Zabel
2016-05-02 21:53 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502145320.f4529b37b32c9ec0a9fc96e1@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=computersforpeace@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rusty@rustcorp.com.au \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®