mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kangjie Lu <kangjielu@gmail.com>
Cc: johnny.kim@atmel.com, austin.shin@atmel.com,
	chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com,
	linux-kernel@vger.kernel.org, taesoo@gatech.edu, insu@gatech.edu,
	csong84@gatech.edu, Kangjie Lu <kjlu@gatech.edu>
Subject: Re: [PATCH] fix infoleak in wilc_wfi_cfgoperations
Date: Tue, 3 May 2016 16:06:29 -0700	[thread overview]
Message-ID: <20160503230629.GB15078@kroah.com> (raw)
In-Reply-To: <1462313848-7858-1-git-send-email-kjlu@gatech.edu>

On Tue, May 03, 2016 at 06:17:28PM -0400, Kangjie Lu wrote:
> "mac" is an array allocated in stack without being initialized,
> and will be sent out via "nla_put". The dump_station() is supposed
> to initialize the mac address; otherwise, sensitive data in kernel
> stack will be leaked. To fix this, initialize it with memset or
> fill it with meaningful mac address.

"or"?  You just set it to zero, why not fix this correctly and put the
real address here?

thanks,

greg k-h

  reply	other threads:[~2016-05-03 23:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 22:17 Kangjie Lu
2016-05-03 23:06 ` Greg KH [this message]
2016-05-04  1:36 Kangjie Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503230629.GB15078@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=csong84@gatech.edu \
    --cc=glen.lee@atmel.com \
    --cc=insu@gatech.edu \
    --cc=johnny.kim@atmel.com \
    --cc=kangjielu@gmail.com \
    --cc=kjlu@gatech.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=taesoo@gatech.edu \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®