From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: <linux-bluetooth@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Ganapathi Bhat <gbhat@marvell.com>
Subject: Re: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell
Date: Thu, 5 May 2016 16:22:38 +0100 [thread overview]
Message-ID: <20160505162238.44f7ed6d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1462460902-25439-3-git-send-email-akarwar@marvell.com>
> +/* Send ACK/NAK to the device */
> +static void mrvl_send_ack(struct hci_uart *hu, unsigned char ack)
> +{
> + struct tty_struct *tty = hu->tty;
> +
> + tty->ops->write(tty, &ack, sizeof(ack));
> +}
You don't know if the device has a write method, and it should be locked.
This should go via your ldisc not directly.
Alan
next prev parent reply other threads:[~2016-05-05 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 15:08 [PATCH v10 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure Amitkumar Karwar
2016-05-05 15:08 ` [PATCH v10 2/3] Bluetooth: hci_uart: check if hdev is present before using it Amitkumar Karwar
2016-05-05 15:08 ` [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell Amitkumar Karwar
2016-05-05 15:22 ` One Thousand Gnomes [this message]
2016-05-05 15:34 ` Amitkumar Karwar
2016-05-05 15:19 ` [PATCH v10 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure One Thousand Gnomes
2016-05-05 15:27 ` Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505162238.44f7ed6d@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=akarwar@marvell.com \
--cc=gbhat@marvell.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®