mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Amitkumar Karwar <akarwar@marvell.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ganapathi Bhat <gbhat@marvell.com>
Subject: RE: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell
Date: Thu, 5 May 2016 15:34:53 +0000	[thread overview]
Message-ID: <14835803c03d47bebec4537e985180fc@SC-EXCH04.marvell.com> (raw)
In-Reply-To: <20160505162238.44f7ed6d@lxorguk.ukuu.org.uk>

Hi Alan,

> From: One Thousand Gnomes [mailto:gnomes@lxorguk.ukuu.org.uk]
> Sent: Thursday, May 05, 2016 8:53 PM
> To: Amitkumar Karwar
> Cc: linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org;
> Ganapathi Bhat
> Subject: Re: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware
> download for Marvell
> 
> > +/* Send ACK/NAK to the device */
> > +static void mrvl_send_ack(struct hci_uart *hu, unsigned char ack) {
> > +	struct tty_struct *tty = hu->tty;
> > +
> > +	tty->ops->write(tty, &ack, sizeof(ack)); }
> 
> You don't know if the device has a write method, and it should be
> locked.
> This should go via your ldisc not directly.
> 

Thanks for review. We will take care of this.

Regards,
Amitkumar

  reply	other threads:[~2016-05-05 15:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-05 15:08 [PATCH v10 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure Amitkumar Karwar
2016-05-05 15:08 ` [PATCH v10 2/3] Bluetooth: hci_uart: check if hdev is present before using it Amitkumar Karwar
2016-05-05 15:08 ` [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell Amitkumar Karwar
2016-05-05 15:22   ` One Thousand Gnomes
2016-05-05 15:34     ` Amitkumar Karwar [this message]
2016-05-05 15:19 ` [PATCH v10 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure One Thousand Gnomes
2016-05-05 15:27   ` Amitkumar Karwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14835803c03d47bebec4537e985180fc@SC-EXCH04.marvell.com \
    --to=akarwar@marvell.com \
    --cc=gbhat@marvell.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®