From: Johannes Thumshirn <jthmshirn@suse.de>
To: Jens Axboe <axboe@fb.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Wenbo Wang <mail_weber_wang@163.com>,
Wenbo Wang <wenbo.wang@memblaze.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
keith.busch@intel.com, wenwei.tao@memblaze.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq
Date: Tue, 10 May 2016 11:13:21 +0200 [thread overview]
Message-ID: <20160510091321.GC22590@c203.arch.suse.de> (raw)
In-Reply-To: <569FC116.5060109@fb.com>
On Wed, Jan 20, 2016 at 10:17:10AM -0700, Jens Axboe wrote:
> On 01/20/2016 10:12 AM, Greg KH wrote:
> > On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
> > > From: Wenbo Wang <wenbo.wang@memblaze.com>
> > >
> > > During reset process, the nvme_dev->bar (ioremapped) may change,
> > > so nvmeq->q_db shall be also updated by nvme_init_queue().
> > >
> > > Currently nvmeq irq is enabled before queue init, so a spurious
> > > interrupt triggered nvme_process_cq may access nvmeq->q_db just
> > > before it is updated, this could cause kernel panic.
> > >
> > > Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
> > > Reviewed-by: Wenwei Tao <wenwei.tao@memblaze.com>
> > > ---
> > > drivers/nvme/host/pci.c | 14 +++++++++-----
> > > 1 file changed, 9 insertions(+), 5 deletions(-)
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
>
> I'll mark it stable when adding, just ignore it for now.
>
> --
> Jens Axboe
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
Ping?
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-05-10 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 10:48 Wenbo Wang
2016-01-20 12:34 ` Sagi Grimberg
2016-01-20 14:57 ` Keith Busch
2016-01-20 15:13 ` Johannes Thumshirn
2016-01-20 17:12 ` Greg KH
2016-01-20 17:17 ` Jens Axboe
2016-05-10 9:13 ` Johannes Thumshirn [this message]
2016-04-25 9:14 ` Johannes Thumshirn
2016-05-11 9:25 ` Johannes Thumshirn
2016-05-11 19:16 ` Keith Busch
2016-05-12 7:12 ` Johannes Thumshirn
2016-05-12 10:55 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510091321.GC22590@c203.arch.suse.de \
--to=jthmshirn@suse.de \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mail_weber_wang@163.com \
--cc=stable@vger.kernel.org \
--cc=wenbo.wang@memblaze.com \
--cc=wenwei.tao@memblaze.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome