From: Peter Zijlstra <peterz@infradead.org>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Jim Cromie <jim.cromie@gmail.com>,
Imre Palik <imrep@amazon.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86: fix undefined shift on 32-bit kernels
Date: Wed, 11 May 2016 16:08:43 +0200 [thread overview]
Message-ID: <20160511140843.GG3192@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1462974711-10037-1-git-send-email-aryabinin@virtuozzo.com>
On Wed, May 11, 2016 at 04:51:51PM +0300, Andrey Ryabinin wrote:
> Jim reported:
> UBSAN: Undefined behaviour in arch/x86/events/intel/core.c:3708:12
> shift exponent 35 is too large for 32-bit type 'long unsigned int'
>
> The use of 'unsigned long' type obviously is not correct here, make it
> 'unsigned long long' instead.
>
> Fixes: 2c33645d366d ("perf/x86: Honor the architectural performance monitoring version")
> Reported-by: Jim Cromie <jim.cromie@gmail.com>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Thanks!
next prev parent reply other threads:[~2016-05-11 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 18:56 rcX probs, UBSAN complaints. one complaint about BIOS Jim Cromie
2016-05-11 13:51 ` [PATCH] perf/x86: fix undefined shift on 32-bit kernels Andrey Ryabinin
2016-05-11 14:08 ` Peter Zijlstra [this message]
2016-05-12 10:34 ` [tip:perf/core] perf/x86: Fix " tip-bot for Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511140843.GG3192@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aryabinin@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=imrep@amazon.de \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®