mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: harvey.hunt@imgtec.com
Cc: marcel@ziswiler.com, robert.jarzmik@free.fr, Baohua.Song@csr.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] drivers: net: Don't print unpopulated net_device name
Date: Tue, 17 May 2016 12:31:21 -0400 (EDT)	[thread overview]
Message-ID: <20160517.123121.1984109840595169844.davem@davemloft.net> (raw)
In-Reply-To: <1463492007-12013-1-git-send-email-harvey.hunt@imgtec.com>

From: Harvey Hunt <harvey.hunt@imgtec.com>
Date: Tue, 17 May 2016 14:33:27 +0100

> For ethernet devices, net_device.name will be eth%d before
> register_netdev() is called. Don't print the net_device name until
> the format string is replaced.
> 
> Signed-off-by: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: Marcel Ziswiler <marcel@ziswiler.com>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Cc: Barry Song <Baohua.Song@csr.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org 
> ---
> v1 -> v2:
>  - Replace ifconfig with ip
>  - Delay printk until the netdev name is known

Yeah this looks a lot better, applied, thanks!

      reply	other threads:[~2016-05-17 16:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 13:33 Harvey Hunt
2016-05-17 16:31 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160517.123121.1984109840595169844.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Baohua.Song@csr.com \
    --cc=harvey.hunt@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@ziswiler.com \
    --cc=netdev@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®