From: Andrew Lunn <andrew@lunn.ch>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
john@phrozen.org
Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver
Date: Thu, 19 May 2016 14:15:43 +0200 [thread overview]
Message-ID: <20160519121543.GB16009@lunn.ch> (raw)
In-Reply-To: <10239730.unHAU2I5Xo@ws-stein>
> To be honest I don't know how the PHY LEDs could be set by LED triggers.
> Wouldn't that require to create triggers for each value which can be written
> to LEDxH and LEDxL? In my case the hardware requires some specific setting due
> to LED connections.
Supporting all possibilities is not possible. However you could
picking out a subset which other PHYs could also implement. Think
about the typical patterns you see if you have two LEDs, which seems
to be the most common setup.
We would have generic PHY trigger code, and a driver specific part
which configures the PHY to that configuration, if the trigger is
activated.
Andrew
next prev parent reply other threads:[~2016-05-19 12:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:03 Alexander Stein
2016-05-18 16:24 ` Florian Fainelli
2016-05-18 17:01 ` Andrew Lunn
2016-05-19 7:05 ` Alexander Stein
2016-05-19 12:15 ` Andrew Lunn [this message]
2016-05-19 4:50 ` John Crispin
2016-05-19 6:57 ` Alexander Stein
2016-05-19 7:03 ` John Crispin
2016-05-19 7:28 ` Alexander Stein
2016-05-19 10:03 ` Mathias Kresin
2016-05-19 10:21 ` Alexander Stein
2016-05-23 9:12 ` Mehrtens, Hauke
2016-05-23 9:49 ` Alexander Stein
2016-05-23 10:07 ` Mathias Kresin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519121543.GB16009@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.stein@systec-electronic.com \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®