mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Serge Hallyn <serge.hallyn@ubuntu.com>
To: Nikolay Borisov <n.borisov.lkml@gmail.com>
Cc: ebiederman@xmission.com, containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] userns: Allow init_user_ns to be used from non-gpl modules
Date: Mon, 23 May 2016 15:12:55 +0000	[thread overview]
Message-ID: <20160523151255.GB1944@ubuntumail> (raw)
In-Reply-To: <1464004808-21214-1-git-send-email-n.borisov.lkml@gmail.com>

Quoting Nikolay Borisov (n.borisov.lkml@gmail.com):
> This patch changes the export attributes of the init_user_ns from
> GPL-only to any modules. This needed so that non-gpl modules, such as
> ZFS, utilize functions like i_(uid|gid)_(read|write).
> 
> Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>

Seems reasonable to me,

Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

but it seems clear the decision belongs to Eric.

thanks,
-serge

> ---
>  kernel/user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/user.c b/kernel/user.c
> index b069ccbfb0b0..8bbd4e628b6e 100644
> --- a/kernel/user.c
> +++ b/kernel/user.c
> @@ -60,7 +60,7 @@ struct user_namespace init_user_ns = {
>  	__RWSEM_INITIALIZER(init_user_ns.persistent_keyring_register_sem),
>  #endif
>  };
> -EXPORT_SYMBOL_GPL(init_user_ns);
> +EXPORT_SYMBOL(init_user_ns);
>  
>  /*
>   * UID task count cache, to get fast user lookup in "alloc_uid"
> -- 
> 2.7.4
> 

  reply	other threads:[~2016-05-23 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 12:00 Nikolay Borisov
2016-05-23 15:12 ` Serge Hallyn [this message]
2016-05-23 16:58 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523151255.GB1944@ubuntumail \
    --to=serge.hallyn@ubuntu.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederman@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n.borisov.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®