From: Tejun Heo <tj@kernel.org>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: Fix an object aliasing bug with `work_data_bits'
Date: Wed, 25 May 2016 16:40:50 -0400 [thread overview]
Message-ID: <20160525204050.GK3354@mtj.duckdns.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1605170915070.6794@tp.orcam.me.uk>
On Tue, May 17, 2016 at 12:04:33PM +0100, Maciej W. Rozycki wrote:
> Fix an aliasing issue causing a MIPS port build error:
>
> In file included from include/linux/srcu.h:34:0,
> from include/linux/notifier.h:15,
> from ./arch/mips/include/asm/uprobes.h:9,
> from include/linux/uprobes.h:61,
> from include/linux/mm_types.h:13,
> from ./arch/mips/include/asm/vdso.h:14,
> from arch/mips/vdso/vdso.h:27,
> from arch/mips/vdso/gettimeofday.c:11:
> include/linux/workqueue.h: In function 'work_static':
> include/linux/workqueue.h:186:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
> return *work_data_bits(work) & WORK_STRUCT_STATIC;
> ^
Umm... the kernel is built explicitly with -fno-strict-aliasing and
it's not something individual archs can opt out.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-05-25 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 11:04 Maciej W. Rozycki
2016-05-25 20:40 ` Tejun Heo [this message]
2016-05-25 21:20 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525204050.GK3354@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®