From: Darren Hart <dvhart@infradead.org>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: "João Paulo Rechi Vita" <jprvita@gmail.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
linux@endlessm.com,
"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: Re: [PATCH 2/5] asus-wmi: Create quirk for airplane_mode LED
Date: Wed, 25 May 2016 14:24:15 -0700 [thread overview]
Message-ID: <20160525212415.GF109010@f23x64.localdomain> (raw)
In-Reply-To: <CAHR064itbc5bWLxX3DyCMmQ3n1gq5SWFhSrBpDqTu=6VjUcsWw@mail.gmail.com>
On Wed, May 25, 2016 at 09:13:23AM +0200, Corentin Chary wrote:
> On Mon, Feb 8, 2016 at 6:05 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
> > Some Asus laptops that have an "airplane mode" indicator LED, also have
> > the WMI WLAN user bit set, and the following bits in their DSDT:
> >
> > Scope (_SB)
> > {
> > (...)
> > Device (ATKD)
> > {
> > (...)
> > Method (WMNB, 3, Serialized)
> > {
> > (...)
> > If (LEqual (IIA0, 0x00010002))
> > {
> > OWGD (IIA1)
> > Return (One)
> > }
> > }
> > }
> > }
> >
> > So when asus-wmi uses ASUS_WMI_DEVID_WLAN_LED (0x00010002) to store the
> > wlan state, it drives the airplane mode indicator LED (through the call
> > to OWGD) in an inverted fashion: the LED is ON when airplane mode is OFF
> > (since wlan is ON), and vice-versa.
> >
> > This commit creates a quirk to not register a RFKill switch at all for
> > these laptops, to allow the asus-wireless driver to drive the airplane
> > mode LED correctly. It also adds a match to that quirk for the Asus
> > X555UB.
>
> This is really something that should get merged, multiple users are
> affected by this. I do not own any of these laptops, but would there
> be a way to detect this behavior instead of having static quircks ?
I believe this is all still blocked on the underlying RFKILL support. João,
correct me if I'm mistaken.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-05-25 21:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 17:05 [PATCH 0/5] asus-wireless: LED control João Paulo Rechi Vita
2016-02-08 17:05 ` [PATCH 1/5] asus-wireless: Toggle airplane mode LED João Paulo Rechi Vita
2016-02-08 17:05 ` [PATCH 2/5] asus-wmi: Create quirk for airplane_mode LED João Paulo Rechi Vita
2016-05-25 7:13 ` Corentin Chary
2016-05-25 16:20 ` João Paulo Rechi Vita
2016-05-25 21:24 ` Darren Hart [this message]
2016-06-13 21:02 ` João Paulo Rechi Vita
2016-02-08 17:05 ` [PATCH 3/5] asus-wmi: Add quirk_no_rfkill for the Asus X552VW João Paulo Rechi Vita
2016-02-08 17:05 ` [PATCH 4/5] asus-wmi: Add quirk_no_rfkill for the Asus U303LB João Paulo Rechi Vita
2016-02-08 17:05 ` [PATCH 5/5] asus-wmi: Add quirk_no_rfkill for the Asus Z550MA João Paulo Rechi Vita
2016-02-08 21:03 ` Darren Hart
2016-02-09 21:39 ` João Paulo Rechi Vita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525212415.GF109010@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=jprvita@endlessm.com \
--cc=jprvita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®