From: Jessica Yu <jeyu@redhat.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Miroslav Benes <mbenes@suse.cz>,
jpoimboe@redhat.com, jikos@kernel.org, jslaby@suse.cz,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
huawei.libin@huawei.com, minfei.huang@yahoo.com
Subject: Re: livepatch: Avoid possible race when releasing the patch
Date: Tue, 31 May 2016 15:00:27 -0400 [thread overview]
Message-ID: <20160531190026.GB23506@packer-debian-8-amd64.digitalocean.com> (raw)
In-Reply-To: <20160530153103.GK23103@pathway.suse.cz>
+++ Petr Mladek [30/05/16 17:31 +0200]:
>On Wed 2016-05-25 10:58:38, Miroslav Benes wrote:
>> On Mon, 23 May 2016, Jessica Yu wrote:
>>
>> > +++ Petr Mladek [23/05/16 17:54 +0200]:
>> > > There was a long discussion about a possible race with sysfs, kobjects
>> > > when removing an unused livepatch, see
>> > > https://lkml.kernel.org/g/%3C1462190242-24731-1-git-send-email-mbenes@suse.cz%3E
>> > >
>> > > This patch set tries to implement what looked the most preferred solution
>> > > from the discussion. I did my best to keep the patch definition simple.
>> > > But I am not super happy with the result.
>> > >
>> > > I send the current state before I spent even more time on different
>> > > approaches.
>> > >
>> > > I personally think that we might get better result if we declare
>> > > some limited structures, define them statically and then copy all
>> > > data into the final structures in a single call. I did not implement
>> > > this because it was weird on the first look but I am not sure now.
>> > >
>> > > But even more I would prefer the solution with the completion.
>> > > It is already used by the module framework. It does not look
>> > > that hacky to me after all.
>> >
>> > Hi Petr, thanks a lot for the RFC and for exploring this possible
>> > solution. I haven't reviewed the patches thoroughly yet, but at first
>> > glance I admit that I did not think through how much this approach
>> > would complicate the livepatch API, and the new intermediary functions
>> > do seem like overkill in response to the original kobject problem..
>> >
>> > I looked at how the module loader used the completion, and in fact
>> > it is used to remedy a nearly identical problem with
>> > DEBUG_KOBJ_RELEASE (see commit 942e443 "Fix mod->mkobj.kobj
>> > potentially freed too early"), and Miroslav's original solution pretty
>> > much took the same approach. We could even mirror that approach and
>> > have something like klp_kobject_put() (much like mod_kobject_put()) to
>> > package up the kobject_put/wait_for_completion calls, but that is
>> > purely a matter of taste.
>>
>> Hi,
>>
>> I'm biased here so it is not surprising that I'd go with completion. There
>> is even one more thing to be aware of. We have 'struct module *mod' in
>> klp_patch and we use it throughout the code. We still need to be careful
>> with it even with Petr's approach. The problem stays but it is greatly
>> diminished to just this one pointer.
>
>Yeah, I forgot to mention that we are actually not able to make
>patch->mod pointer valid without the completion.
>
>I gave it another week and I have got even more convinced that the
>completion would be the right way to go. It is not that hacky after all
>and it might safe us some headaches in the future. IMHO,
>it is too painful to copy all information from the module just
>to make kobjects happy.
Ah yeah, good catch. So even if livepatch internally managed these
structures, the mod pointer in klp_patch still wouldn't be protected,
which the completion trivially fixes. So I'd be OK with the completion
as well. Thanks for the RFC though Petr, in my head it sounded like a
good idea in theory, but in practice turned out to be too cumbersome.
Jessica
prev parent reply other threads:[~2016-05-31 19:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 15:54 [RFC PATCH 0/2] " Petr Mladek
2016-05-23 15:54 ` [RFC PATCH 1/2] livepatch: Extend the livepatch-sample patch Petr Mladek
2016-05-23 15:54 ` [RFC PATCH 2/2] livepatch: Use kobjects the right way Petr Mladek
2016-05-23 16:30 ` [RFC PATCH 0/2] livepatch: Avoid possible race when releasing the patch Josh Poimboeuf
2016-05-23 21:35 ` Jessica Yu
2016-05-25 8:58 ` Miroslav Benes
2016-05-30 15:31 ` Petr Mladek
2016-05-31 18:40 ` Josh Poimboeuf
2016-05-31 19:00 ` Jessica Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531190026.GB23506@packer-debian-8-amd64.digitalocean.com \
--to=jeyu@redhat.com \
--cc=huawei.libin@huawei.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=minfei.huang@yahoo.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®