From: David Miller <davem@davemloft.net>
To: bhaktipriya96@gmail.com
Cc: akinobu.mita@gmail.com, a@unstable.cc,
felipe.balbi@linux.intel.com, fw@strlen.de, tj@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: wiznet: Remove create_workqueue
Date: Thu, 02 Jun 2016 12:15:41 -0700 (PDT) [thread overview]
Message-ID: <20160602.121541.1591890175711948513.davem@davemloft.net> (raw)
In-Reply-To: <20160601175914.GA5169@Karyakshetra>
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Date: Wed, 1 Jun 2016 23:29:15 +0530
> alloc_workqueue replaces deprecated create_workqueue().
>
> A dedicated workqueue has been used since the workitems are involved
> in normal device operation. Workitems &priv->rx_work and &priv->tx_work,
> map to w5100_rx_work and w5100_tx_work respectively and are involved in
> receiving and transmitting packets. Forward progress under
> memory pressure is a requirement here.
>
> create_workqueue has been replaced with alloc_workqueue with max_active
> as 0 since there is no need for throttling the number of active work
> items.
>
> Since the driver may be used in memory reclaim path,
> WQ_MEM_RECLAIM has been set to guarantee forward progress.
>
> flush_workqueue is unnecessary since destroy_workqueue() itself calls
> drain_workqueue() which flushes repeatedly till the workqueue
> becomes empty. Hence the call to flush_workqueue() has been dropped.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2016-06-02 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 17:59 Bhaktipriya Shridhar
2016-06-01 18:46 ` Tejun Heo
2016-06-02 19:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602.121541.1591890175711948513.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a@unstable.cc \
--cc=akinobu.mita@gmail.com \
--cc=bhaktipriya96@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®