From: David Miller <davem@davemloft.net>
To: thloh@altera.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
peppe.cavallaro@st.com, dinguyen@altera.com, thloh85@gmail.com,
cnphoon@altera.com, phooncn@gmail.com
Subject: Re: [PATCH 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga
Date: Sun, 05 Jun 2016 23:11:02 -0400 (EDT) [thread overview]
Message-ID: <20160605.231102.1130873370221997319.davem@davemloft.net> (raw)
In-Reply-To: <1464944835-21575-1-git-send-email-thloh@altera.com>
From: <thloh@altera.com>
Date: Fri, 3 Jun 2016 02:07:15 -0700
> From: Tien Hock Loh <thloh@altera.com>
>
> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> the dwmac is set to sgmii
>
> Signed-off-by: Tien Hock Loh <thloh@altera.com>
Please at least make an effort to use consistent coding style.
You rework this function to do this:
> - if (!splitter_base)
> - return;
> + if (splitter_base) {
And then you add something like this:
> + if ((tse_pcs_base) && (sgmii_adapter_base)) {
> + tse_pcs_fix_mac_speed(&dwmac->pcs, phy_dev, speed);
> + }
Excessive parenthesis in the if() condition, and single statement
basic blocks do not get curly braces.
prev parent reply other threads:[~2016-06-06 3:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 9:07 thloh
2016-06-06 3:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160605.231102.1130873370221997319.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cnphoon@altera.com \
--cc=dinguyen@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=phooncn@gmail.com \
--cc=thloh85@gmail.com \
--cc=thloh@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®