mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ken Moffat <zarniwhoop@ntlworld.com>
To: Justin Keller <justincompsci@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] documentation: ntb.txt correct grammar "however"
Date: Sun, 5 Jun 2016 02:36:09 +0100	[thread overview]
Message-ID: <20160605013609.GA25079@milliways.localdomain> (raw)
In-Reply-To: <8CC2D7F1-5F56-411B-877F-40CD04DD1FEB@gmail.com>

On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote:
> Correct the grammar around the word however. 
> 
> Signed-off-by: Justin Keller <justincompsci@gmail.com>
> 
> --- 
> 
> index 1d9bbab..5d43510 100644
> --- a/Documentation/ntb.txt
> +++ b/Documentation/ntb.txt
> @@ -35,7 +35,7 @@ establishes a logical link to the peer, and creates queue pairs to exchange
>  messages and data.  The NTB Netdev then creates an ethernet device using a
>  Transport queue pair.  Network data is copied between socket buffers and the
>  Transport queue pair buffer.  The Transport client may be used for other things
> -besides Netdev, however no other applications have yet been written.
> +besides Netdev; however, no other applications have yet been written.
>  
>  ### NTB Ping Pong Test Client (ntb\_pingpong)

As a user of British English, the original looks fine.  Your change,
however, looks odd - a semi-colon seems out of place.  If you
replaced it by a full-stop it would look acceptable to me - but not
in any sense better than what is there at the moment.

ĸen
-- 
I had to walk fifteen miles to school, barefoot in the snow.  Uphill both ways.

  reply	other threads:[~2016-06-05  1:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 19:34 Justin Keller
2016-06-05  1:36 ` Ken Moffat [this message]
2016-06-06 18:56   ` Austin S. Hemmelgarn
2016-06-06 19:06     ` Allen Hubbe
2016-06-06 19:09       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160605013609.GA25079@milliways.localdomain \
    --to=zarniwhoop@ntlworld.com \
    --cc=justincompsci@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®