mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alexander Graf <agraf@suse.de>
Cc: rtc-linux@googlegroups.com, leif.lindholm@linaro.org,
	linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] rtc: efi: Fail probing if RTC reads don't work
Date: Mon, 6 Jun 2016 17:08:05 +0200	[thread overview]
Message-ID: <20160606150805.GB3363@piout.net> (raw)
In-Reply-To: <1465119356-129799-1-git-send-email-agraf@suse.de>

On 05/06/2016 at 11:35:56 +0200, Alexander Graf wrote :
> While the EFI spec mandates an RTC, not every implementation actually adheres
> to that rule (or can adhere to it - some systems just don't have an RTC).
> 
> For those, we really don't want to probe the EFI RTC driver at all, because if
> we do we'd get a non-functional driver that does nothing useful but only spills
> our kernel log with warnings.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  drivers/rtc/rtc-efi.c | 6 ++++++
>  1 file changed, 6 insertions(+)
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2016-06-06 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-05  9:35 Alexander Graf
2016-06-06  8:54 ` Ard Biesheuvel
2016-06-06 15:08 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160606150805.GB3363@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=agraf@suse.de \
    --cc=ard.biesheuvel@linaro.org \
    --cc=leif.lindholm@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®