mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Emese Revfy <re.emese@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Michal Marek <mmarek@suse.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Linux-Next <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH] gcc-plugins: disable under COMPILE_TEST
Date: Mon, 13 Jun 2016 02:18:31 +0200	[thread overview]
Message-ID: <20160613021831.9a79c5c82d1511e572023ed6@gmail.com> (raw)
In-Reply-To: <CAGXu5jJ_+azG6H0tB7W0mJTUzXp18Y7qN7dx7EEKng+0nO-dig@mail.gmail.com>

On Sun, 12 Jun 2016 15:25:39 -0700
Kees Cook <keescook@chromium.org> wrote:

> I don't like this because it means if someone specifically selects
> some plugins in their .config, and the headers are missing, the kernel
> will successfully compile. For many plugins, this results in a kernel
> that lacks the requested security features, and that I really do not
> want to have happening. I'm okay leaving these disabled for compile
> tests for now. We can revisit this once more distros have plugins
> enabled by default.

You are right. Your patch is safer.

-- 
Emese

  reply	other threads:[~2016-06-13  0:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-11 16:12 Kees Cook
2016-06-11 16:29 ` Paul Gortmaker
2016-06-12 22:12   ` Emese Revfy
2016-06-12 22:25     ` Kees Cook
2016-06-13  0:18       ` Emese Revfy [this message]
2016-06-13 18:32         ` Austin S. Hemmelgarn
2016-06-13 20:11           ` Kees Cook
2016-06-14  2:01             ` Michael Ellerman
2016-06-13  7:52 ` Sudip Mukherjee
2016-06-13  8:40 ` Sedat Dilek
2016-06-13 20:15   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160613021831.9a79c5c82d1511e572023ed6@gmail.com \
    --to=re.emese@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®