From: David Miller <davem@davemloft.net>
To: msw@amzn.com
Cc: netanel@annapurnalabs.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, zorik@annapurnalabs.com,
saeed@annapurnalabs.com, alex@annapurnalabs.com,
aliguori@amazon.com, antoine.tenart@free-electrons.com
Subject: Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)
Date: Tue, 14 Jun 2016 23:27:09 -0700 (PDT) [thread overview]
Message-ID: <20160614.232709.326751260784989181.davem@davemloft.net> (raw)
In-Reply-To: <20160615062336.GA26911@u54ee753d2d1854bda401.ant.amazon.com>
From: Matt Wilson <msw@amzn.com>
Date: Tue, 14 Jun 2016 23:23:36 -0700
> Point taken, though existing drivers (even fairly popular ones) also
> aren't as clean as you might like. A quick look around...
Existing drivers do undesirable things, film at 11...
Yet are never a reason to accept such things in new drivers.
> Like many other network drivers, some of this is common code used for
> non-Linux systems, and that's why there is some overlap with Linux
> facilities.
Again, never an excuse for such things.
> Are there other things that jump out at you?
I review hundreds of patches a day, I invested what I was able to
before moving on to other people's work.
Other developers must help review such a large driver submission, it
can't all be on me.
next prev parent reply other threads:[~2016-06-15 6:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 8:46 Netanel Belgazal
2016-06-13 20:36 ` Matt Wilson
2016-06-15 5:25 ` David Miller
2016-06-15 6:23 ` Matt Wilson
2016-06-15 6:27 ` David Miller [this message]
2016-06-15 6:40 ` Matt Wilson
2016-06-15 18:07 ` Matt Wilson
2016-06-15 18:22 ` Matt Wilson
[not found] ` <CAO+Uck_mkRmhkFedb1FsbvuEFFebhYEfYb1UqM+VGSFfKFWN0Q@mail.gmail.com>
2016-06-15 18:39 ` Matt Wilson
2016-06-16 17:55 ` Benjamin Poirier
2016-06-16 18:06 ` Ben Hutchings
2016-06-18 6:16 ` Matt Wilson
2016-06-16 20:46 ` Francois Romieu
2016-06-17 1:09 ` Matt Wilson
2016-06-20 15:18 ` Netanel Belgazal
2016-06-17 21:11 ` Francois Romieu
2016-06-20 15:32 ` Netanel Belgazal
2016-06-20 22:43 ` Francois Romieu
2016-06-21 10:02 ` Netanel Belgazal
2016-06-20 5:20 ` Rosen, Rami
2016-06-20 15:42 ` Netanel Belgazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614.232709.326751260784989181.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=antoine.tenart@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amzn.com \
--cc=netanel@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®