mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Vesely, Jan" <Jan.Vesely@amd.com>
Cc: "joro@8bytes.org" <joro@8bytes.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain
Date: Wed, 15 Jun 2016 22:53:11 +0200	[thread overview]
Message-ID: <20160615205311.GB19822@pd.tnic> (raw)
In-Reply-To: <1466013192.3265.74.camel@amd.com>

On Wed, Jun 15, 2016 at 05:53:15PM +0000, Vesely, Jan wrote:
> There are no specific bugs/oopses that these patches fix (that I'm
> aware of). Both were found while I was familiarizing myself with the
> code looking for memory corruption (which turned out to be [0]).
> Either issue would be very difficult to hit in the wild and
> mutex_destroy is empty unless you compile using CONFIG_DEBUG_MUTEXES.

See Documentation/SubmittingPatches which explains what "Fixes:" means.

That same file also contains info in section 2) how to write commit
messages.

Please read it, it'll help you significantly if you're planning on
sending more patches to LKML.

> [0] https://lkml.org/lkml/2016/3/7/1087

Oh, and also, please don't use any web pages archiving lkml as pointers
but the kernel.org redirector:

http://lkml.kernel.org/r/<Message-ID>

or

http://lkml.kernel.org/g/<Message-ID>

(that second one redirects to gmane)

HTH.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

  reply	other threads:[~2016-06-15 20:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21 18:11 [PATCH 1/2] iommu/amd: Remove entry from the list before freeing it Jan Vesely
2016-05-21 18:11 ` [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain Jan Vesely
2016-06-09 15:48   ` Vesely, Jan
2016-06-15 11:54     ` joro
2016-06-15 17:53       ` Vesely, Jan
2016-06-15 20:53         ` Borislav Petkov [this message]
2016-06-28 16:48           ` Vesely, Jan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615205311.GB19822@pd.tnic \
    --to=bp@alien8.de \
    --cc=Jan.Vesely@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®