From: Tejun Heo <tj@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, linux-ide@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: fix "ering" sysfs time printing
Date: Fri, 17 Jun 2016 12:10:53 -0400 [thread overview]
Message-ID: <20160617161053.GK3262@mtj.duckdns.org> (raw)
In-Reply-To: <20160617153739.429055-1-arnd@arndb.de>
On Fri, Jun 17, 2016 at 05:37:12PM +0200, Arnd Bergmann wrote:
> The sysfs file for the libata error handling has multiple issues
> in the way it prints time stamps:
>
> * it prints a 9-digit nanosecond value using a %06lu format string,
> which drops some leading zeroes
> * it converts a 64-bit jiffes value to a timespec using
> jiffies_to_timespec(), which takes a 'long' argument, so the
> result is wrong after a jiffies overflow (49 days).
> * we try to avoid using timespec because that generally overflows
> in 2038, although this particular usage is ok.
>
> This replaces the jiffies_to_timespec call with an open-coded
> implementation that gets it right.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Heh, I'm not even sure why we're exposing this but it's already there.
Applied to libata/for-4.8.
Thanks!
--
tejun
prev parent reply other threads:[~2016-06-17 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 15:37 Arnd Bergmann
2016-06-17 16:10 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617161053.GK3262@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®