From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Oleg Nesterov <oleg@redhat.com>,
Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pedro Alves <palves@redhat.com>,
Roland McGrath <roland@hack.frob.com>
Subject: Re: [PATCH] x86/ptrace: Remove questionable TS_COMPAT usage in ptrace
Date: Mon, 20 Jun 2016 13:12:43 +0200 [thread overview]
Message-ID: <20160620111243.GA8689@host1.jankratochvil.net> (raw)
In-Reply-To: <177f65bb-dab9-9a1e-73a8-506904192bb2@palves.net>
On Mon, 20 Jun 2016 12:07:56 +0200, Pedro Alves wrote:
> On 06/18/2016 06:02 PM, Andy Lutomirski wrote:
> > Yuck. I should have dug in to the history. Why not just
> > unconditionally sign-extend eax when set by a 32-bit tracer?
>
> No idea.
Roland McGrath knows why he wrote it that way, Cced.
What if eax contains an address in 2GB..4GB range? I guess currently the
orig_eax check tries to verify %eax cannot contain an address.
Jan
next prev parent reply other threads:[~2016-06-20 11:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 10:21 Andy Lutomirski
2016-06-18 13:55 ` Pedro Alves
2016-06-18 14:41 ` Pedro Alves
2016-06-18 17:02 ` Andy Lutomirski
2016-06-19 22:09 ` Andy Lutomirski
2016-06-20 10:27 ` Pedro Alves
2016-06-20 15:24 ` Oleg Nesterov
2016-06-20 16:30 ` Andy Lutomirski
2016-06-20 16:14 ` Oleg Nesterov
2016-06-20 17:25 ` Andy Lutomirski
2016-06-20 10:07 ` Pedro Alves
2016-06-20 11:12 ` Jan Kratochvil [this message]
2016-06-18 17:48 ` Kees Cook
2016-06-19 21:19 ` Oleg Nesterov
2016-06-19 22:23 ` Andy Lutomirski
2016-06-20 6:12 ` Andy Lutomirski
2016-06-20 15:31 ` Oleg Nesterov
2016-06-20 17:53 ` the usage of __SYSCALL_MASK in entry_SYSCALL_64/do_syscall_64 is not consistent Oleg Nesterov
2016-06-21 19:01 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620111243.GA8689@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=bp@alien8.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=palves@redhat.com \
--cc=roland@hack.frob.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome