From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ben Dooks <ben.dooks@codethink.co.uk>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses
Date: Mon, 20 Jun 2016 18:30:53 +0200 [thread overview]
Message-ID: <20160620163053.GE22920@lunn.ch> (raw)
In-Reply-To: <20160620160337.2934-15-vivien.didelot@savoirfairelinux.com>
On Mon, Jun 20, 2016 at 12:03:37PM -0400, Vivien Didelot wrote:
> When the SMI address of the switch chip is zero, the chip assumes to be
> the only one on the SMI master bus and thus responds to all its known
> SMI devices addresses (port registers, Global2, etc.)
>
> When its SMI address is not zero, some chips (e.g. 88E6352) use an
> indirect access through two SMI Command and Data registers.
>
> Other models (e.g. 88E6060) using less than 16 internal SMI addresses
> always use a direct access.
>
> Add a capability flag to describe chips supporting the (indirect)
> Multi-chip Addressing Mode, and a low-level API to access the registers
> via SMI.
>
> Other accesses (like Ethernet management frames) may be added later.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
This series is now ready for merging.
Thanks
Andrew
next prev parent reply other threads:[~2016-06-20 16:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 16:03 [PATCH v4 net-next v4 00/14] net: dsa: mv88e6xxx: probe compatible Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 01/14] net: dsa: mv88e6xxx: fix style issues Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 02/14] net: dsa: mv88e6xxx: remove redundant assignments Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 03/14] net: dsa: mv88e6xxx: use already declared variables Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 04/14] net: dsa: mv88e6xxx: do not increment bus refcount Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 05/14] net: dsa: mv88e6xxx: add switch register helpers Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 06/14] net: dsa: mv88e6xxx: use gpio get optional variant Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 07/14] net: dsa: mv88e6xxx: remove table args in info lookup Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 08/14] net: dsa: mv88e6xxx: rename smi_mutex to reg_lock Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 09/14] net: dsa: mv88e6xxx: add chip allocation helper Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 10/14] net: dsa: mv88e6xxx: add SMI init helper Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 11/14] net: dsa: mv88e6xxx: add detection helper Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 12/14] net: dsa: mv88e6xxx: pass compatible info Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 13/14] net: dsa: mv88e6xxx: add port base address to info Vivien Didelot
2016-06-20 16:03 ` [PATCH v4 net-next v4 14/14] net: dsa: mv88e6xxx: abstract switch registers accesses Vivien Didelot
2016-06-20 16:30 ` Andrew Lunn [this message]
2016-06-20 17:03 ` Vivien Didelot
2016-06-20 18:25 ` kbuild test robot
2016-06-20 18:32 ` kbuild test robot
2016-06-20 18:33 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160620163053.GE22920@lunn.ch \
--to=andrew@lunn.ch \
--cc=ben.dooks@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®