* [PATCH] arm64: add boot image dependencies to not generate invalid images
@ 2016-06-21 1:44 Masahiro Yamada
2016-06-21 10:32 ` Catalin Marinas
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2016-06-21 1:44 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Masahiro Yamada, Will Deacon, Catalin Marinas, linux-kernel
I fixed boot image dependencies for arch/arm in commit 3939f3345050
("ARM: 8418/1: add boot image dependencies to not generate invalid
images").
I see a similar problem for arch/arm64; "make -jN Image Image.gz"
would sometimes end up generating bad images where N > 1.
Fix the dependency in arch/arm64/Makefile to avoid the race
between "make Image" and "make Image.*".
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm64/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 7085e32..648a32c 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -95,7 +95,7 @@ boot := arch/arm64/boot
Image: vmlinux
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
-Image.%: vmlinux
+Image.%: Image
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
zinstall install:
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: add boot image dependencies to not generate invalid images
2016-06-21 1:44 [PATCH] arm64: add boot image dependencies to not generate invalid images Masahiro Yamada
@ 2016-06-21 10:32 ` Catalin Marinas
2016-06-21 10:34 ` Will Deacon
2016-06-21 10:36 ` Masahiro Yamada
0 siblings, 2 replies; 4+ messages in thread
From: Catalin Marinas @ 2016-06-21 10:32 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-arm-kernel, Will Deacon, linux-kernel
On Tue, Jun 21, 2016 at 10:44:00AM +0900, Masahiro Yamada wrote:
> I fixed boot image dependencies for arch/arm in commit 3939f3345050
> ("ARM: 8418/1: add boot image dependencies to not generate invalid
> images").
>
> I see a similar problem for arch/arm64; "make -jN Image Image.gz"
> would sometimes end up generating bad images where N > 1.
>
> Fix the dependency in arch/arm64/Makefile to avoid the race
> between "make Image" and "make Image.*".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Will, could you please pick this up for 4.7? Maybe with a cc stable.
Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: add boot image dependencies to not generate invalid images
2016-06-21 10:32 ` Catalin Marinas
@ 2016-06-21 10:34 ` Will Deacon
2016-06-21 10:36 ` Masahiro Yamada
1 sibling, 0 replies; 4+ messages in thread
From: Will Deacon @ 2016-06-21 10:34 UTC (permalink / raw)
To: Catalin Marinas; +Cc: Masahiro Yamada, linux-arm-kernel, linux-kernel
On Tue, Jun 21, 2016 at 11:32:17AM +0100, Catalin Marinas wrote:
> On Tue, Jun 21, 2016 at 10:44:00AM +0900, Masahiro Yamada wrote:
> > I fixed boot image dependencies for arch/arm in commit 3939f3345050
> > ("ARM: 8418/1: add boot image dependencies to not generate invalid
> > images").
> >
> > I see a similar problem for arch/arm64; "make -jN Image Image.gz"
> > would sometimes end up generating bad images where N > 1.
> >
> > Fix the dependency in arch/arm64/Makefile to avoid the race
> > between "make Image" and "make Image.*".
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
> Will, could you please pick this up for 4.7? Maybe with a cc stable.
Yup, will do.
Will
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: add boot image dependencies to not generate invalid images
2016-06-21 10:32 ` Catalin Marinas
2016-06-21 10:34 ` Will Deacon
@ 2016-06-21 10:36 ` Masahiro Yamada
1 sibling, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2016-06-21 10:36 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon; +Cc: Linux Kernel Mailing List, linux-arm-kernel
2016-06-21 19:32 GMT+09:00 Catalin Marinas <catalin.marinas@arm.com>:
> On Tue, Jun 21, 2016 at 10:44:00AM +0900, Masahiro Yamada wrote:
>> I fixed boot image dependencies for arch/arm in commit 3939f3345050
>> ("ARM: 8418/1: add boot image dependencies to not generate invalid
>> images").
>>
>> I see a similar problem for arch/arm64; "make -jN Image Image.gz"
>> would sometimes end up generating bad images where N > 1.
>>
>> Fix the dependency in arch/arm64/Makefile to avoid the race
>> between "make Image" and "make Image.*".
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
>
> Will, could you please pick this up for 4.7? Maybe with a cc stable.
> Thanks.
If possible, could you change the subject?
arm64: add boot image dependencies to not generate invalid images
--->
arm64: fix boot image dependencies to not generate invalid images
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-21 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21 1:44 [PATCH] arm64: add boot image dependencies to not generate invalid images Masahiro Yamada
2016-06-21 10:32 ` Catalin Marinas
2016-06-21 10:34 ` Will Deacon
2016-06-21 10:36 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®