From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCHv3 1/2] usb: USB Type-C connector class
Date: Thu, 23 Jun 2016 11:25:49 +0300 [thread overview]
Message-ID: <20160623082549.GB27263@kuha.fi.intel.com> (raw)
In-Reply-To: <20160622215428.GA15297@roeck-us.net>
Hi,
On Wed, Jun 22, 2016 at 02:54:28PM -0700, Guenter Roeck wrote:
> Hi,
>
> > +
> > +static void typec_remove_partner(struct typec_port *port)
> > +{
> > + WARN_ON(port->partner->alt_modes);
>
> You are setting partner->alt_modes in typec_register_altmodes(),
> but you don't clear it in typec_unregister_altmodes().
>
> Does this work for you ? I always get the warning when I remove a cable.
Damn it.. I have managed to just ignore the warning.
Yeah, this has to be fixed. Sorry about that.
Thanks,
--
heikki
next prev parent reply other threads:[~2016-06-23 8:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 14:51 [PATCHv3 0/2] USB Type-C Connector class Heikki Krogerus
2016-06-21 14:51 ` [PATCHv3 1/2] usb: USB Type-C connector class Heikki Krogerus
2016-06-21 20:25 ` Oliver Neukum
2016-06-22 9:50 ` Heikki Krogerus
2016-06-22 10:03 ` Heikki Krogerus
2016-06-22 10:21 ` Oliver Neukum
2016-06-22 10:14 ` Oliver Neukum
2016-06-22 11:44 ` Heikki Krogerus
2016-06-22 13:47 ` Oliver Neukum
2016-06-22 14:38 ` Heikki Krogerus
2016-06-22 16:44 ` Oliver Neukum
2016-06-23 8:23 ` Heikki Krogerus
2016-06-23 8:38 ` Oliver Neukum
2016-06-23 12:00 ` Heikki Krogerus
2016-06-23 12:25 ` Roger Quadros
2016-06-23 13:11 ` Heikki Krogerus
2016-06-23 13:29 ` Guenter Roeck
2016-06-22 21:54 ` Guenter Roeck
2016-06-23 8:25 ` Heikki Krogerus [this message]
2016-06-23 11:53 ` Roger Quadros
2016-06-23 13:08 ` Heikki Krogerus
[not found] ` <CAOiXhaKhPfY0Bz8TsZMFQsgLHZZ01DwZ=TPcXtH2nYvHx3PqVA@mail.gmail.com>
[not found] ` <20160627095120.GC20801@kuha.fi.intel.com>
[not found] ` <CAOiXhaJiche=jGbg_C2Jbmw1BnA5UYVNKOfhmy4CFiugoPV_+w@mail.gmail.com>
2016-06-27 12:13 ` Heikki Krogerus
2016-06-27 13:39 ` Guenter Roeck
2016-06-28 13:12 ` Heikki Krogerus
2016-06-28 13:28 ` Guenter Roeck
2016-06-29 8:51 ` Rajaram R
2016-06-29 10:30 ` Heikki Krogerus
2016-06-29 10:51 ` Rajaram R
2016-06-29 11:27 ` Heikki Krogerus
2016-07-04 8:55 ` Oliver Neukum
2016-06-21 14:51 ` [PATCHv3 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Heikki Krogerus
2016-06-21 22:25 ` [PATCHv3 0/2] USB Type-C Connector class Guenter Roeck
2016-06-22 9:51 ` Heikki Krogerus
2016-06-22 13:24 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160623082549.GB27263@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®