mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: pi3orama <pi3orama@163.com>
Cc: Wang Nan <wangnan0@huawei.com>,
	acme@kernel.org, linux-kernel@vger.kernel.org,
	lizefan@huawei.com
Subject: Re: [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF
Date: Fri, 24 Jun 2016 14:55:38 +0200	[thread overview]
Message-ID: <20160624125538.GA18012@krava> (raw)
In-Reply-To: <887CD4AB-AD56-40A0-9DD1-93D0767474B3@163.com>

On Fri, Jun 24, 2016 at 08:33:27PM +0800, pi3orama wrote:

SNIP

> > I can't compile unless I can include config.h
> > 
> > [jolsa@krava perf]$ make LIBBABELTRACE_DIR=/opt/libbabeltrace/ LIBBABELTRACE=1
> >  BUILD:   Doing 'make -j4' parallel build
> >  CC       util/data-convert-bt.o
> > util/data-convert-bt.c: In function ‘convert__config’:
> > util/data-convert-bt.c:1299:19: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
> >   c->queue_size = perf_config_u64(var, value);
> >                   ^
> > util/data-convert-bt.c:1299:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
> >   c->queue_size = perf_config_u64(var, value);
> >   ^
> > util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> > util/data-convert-bt.c:1332:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
> >  perf_config(convert__config, &c);
> >  ^
> > util/data-convert-bt.c:1332:2: error: nested extern declaration of ‘perf_config’ [-Werror=nested-externs]
> > cc1: all warnings being treated as errors
> > 
> 
> Strange.
> 
> The error message seems unrelated to my
> patch, right?

yep, it's unrelated and I just posted the fix

I haven't enabled/compiled this code for a while and that's
what I've got.. I assume we're using different compilers

jirka

  reply	other threads:[~2016-06-24 12:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 11:22 Wang Nan
2016-06-24 11:22 ` [PATCH v2 1/7] perf ctf: Add value_set_string() helper Wang Nan
2016-06-29  9:45   ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 2/7] perf ctf: Pass convert options through opts structure Wang Nan
2016-06-29  9:45   ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 3/7] perf ctf: Add 'all' option Wang Nan
2016-06-29  9:46   ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 4/7] perf ctf: Prepare collect non-sample events Wang Nan
2016-06-29  9:46   ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 5/7] perf ctf: Generate comm event to CTF output Wang Nan
2016-06-29  9:46   ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 6/7] perf ctf: Add '--all' option for 'perf data convert' Wang Nan
2016-06-29  9:47   ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 7/7] perf ctf: Generate fork and exit events to CTF output Wang Nan
2016-06-29  9:47   ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 12:28 ` [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Jiri Olsa
2016-06-27 19:03   ` Arnaldo Carvalho de Melo
2016-06-24 12:29 ` Jiri Olsa
2016-06-24 12:33   ` pi3orama
2016-06-24 12:55     ` Jiri Olsa [this message]
2016-06-24 12:41   ` Arnaldo Carvalho de Melo
2016-06-24 12:43     ` pi3orama
2016-06-24 13:08       ` Jiri Olsa
2016-06-24 12:44     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160624125538.GA18012@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=pi3orama@163.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome