From: tip-bot for Wang Nan <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: jolsa@kernel.org, wangnan0@huawei.com, lizefan@huawei.com,
mingo@kernel.org, tglx@linutronix.de, acme@redhat.com,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: [tip:perf/core] perf data ctf: Pass convert options through opts structure
Date: Wed, 29 Jun 2016 02:45:38 -0700 [thread overview]
Message-ID: <tip-3275f68e50290acd04612c6af41173fe83fdf4b0@git.kernel.org> (raw)
In-Reply-To: <1466767332-114472-3-git-send-email-wangnan0@huawei.com>
Commit-ID: 3275f68e50290acd04612c6af41173fe83fdf4b0
Gitweb: http://git.kernel.org/tip/3275f68e50290acd04612c6af41173fe83fdf4b0
Author: Wang Nan <wangnan0@huawei.com>
AuthorDate: Fri, 24 Jun 2016 11:22:07 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 28 Jun 2016 10:54:55 -0300
perf data ctf: Pass convert options through opts structure
Following commits will add new option to 'perf data convert'. All options
should be grouped into a structure and passed to low level converter
(currently there's only one converter).
Introduce data-convert.h and define 'struct perf_data_convert_opts' in
it. Pass 'force' through opts.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1466767332-114472-3-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-data.c | 9 ++++++---
tools/perf/util/data-convert-bt.c | 5 +++--
tools/perf/util/data-convert-bt.h | 4 +++-
tools/perf/util/data-convert.h | 8 ++++++++
4 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/tools/perf/builtin-data.c b/tools/perf/builtin-data.c
index b97bc15..38111a9 100644
--- a/tools/perf/builtin-data.c
+++ b/tools/perf/builtin-data.c
@@ -3,6 +3,7 @@
#include "perf.h"
#include "debug.h"
#include <subcmd/parse-options.h>
+#include "data-convert.h"
#include "data-convert-bt.h"
typedef int (*data_cmd_fn_t)(int argc, const char **argv, const char *prefix);
@@ -53,14 +54,16 @@ static int cmd_data_convert(int argc, const char **argv,
const char *prefix __maybe_unused)
{
const char *to_ctf = NULL;
- bool force = false;
+ struct perf_data_convert_opts opts = {
+ .force = false,
+ };
const struct option options[] = {
OPT_INCR('v', "verbose", &verbose, "be more verbose"),
OPT_STRING('i', "input", &input_name, "file", "input file name"),
#ifdef HAVE_LIBBABELTRACE_SUPPORT
OPT_STRING(0, "to-ctf", &to_ctf, NULL, "Convert to CTF format"),
#endif
- OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
+ OPT_BOOLEAN('f', "force", &opts.force, "don't complain, do it"),
OPT_END()
};
@@ -78,7 +81,7 @@ static int cmd_data_convert(int argc, const char **argv,
if (to_ctf) {
#ifdef HAVE_LIBBABELTRACE_SUPPORT
- return bt_convert__perf2ctf(input_name, to_ctf, force);
+ return bt_convert__perf2ctf(input_name, to_ctf, &opts);
#else
pr_err("The libbabeltrace support is not compiled in.\n");
return -1;
diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index 4b68e7b..09571b3 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -1304,13 +1304,14 @@ static int convert__config(const char *var, const char *value, void *cb)
return 0;
}
-int bt_convert__perf2ctf(const char *input, const char *path, bool force)
+int bt_convert__perf2ctf(const char *input, const char *path,
+ struct perf_data_convert_opts *opts)
{
struct perf_session *session;
struct perf_data_file file = {
.path = input,
.mode = PERF_DATA_MODE_READ,
- .force = force,
+ .force = opts->force,
};
struct convert c = {
.tool = {
diff --git a/tools/perf/util/data-convert-bt.h b/tools/perf/util/data-convert-bt.h
index 4c20434..9a3b587 100644
--- a/tools/perf/util/data-convert-bt.h
+++ b/tools/perf/util/data-convert-bt.h
@@ -1,8 +1,10 @@
#ifndef __DATA_CONVERT_BT_H
#define __DATA_CONVERT_BT_H
+#include "data-convert.h"
#ifdef HAVE_LIBBABELTRACE_SUPPORT
-int bt_convert__perf2ctf(const char *input_name, const char *to_ctf, bool force);
+int bt_convert__perf2ctf(const char *input_name, const char *to_ctf,
+ struct perf_data_convert_opts *opts);
#endif /* HAVE_LIBBABELTRACE_SUPPORT */
#endif /* __DATA_CONVERT_BT_H */
diff --git a/tools/perf/util/data-convert.h b/tools/perf/util/data-convert.h
new file mode 100644
index 0000000..97cfd36
--- /dev/null
+++ b/tools/perf/util/data-convert.h
@@ -0,0 +1,8 @@
+#ifndef __DATA_CONVERT_H
+#define __DATA_CONVERT_H
+
+struct perf_data_convert_opts {
+ bool force;
+};
+
+#endif /* __DATA_CONVERT_H */
next prev parent reply other threads:[~2016-06-29 9:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 11:22 [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Wang Nan
2016-06-24 11:22 ` [PATCH v2 1/7] perf ctf: Add value_set_string() helper Wang Nan
2016-06-29 9:45 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 2/7] perf ctf: Pass convert options through opts structure Wang Nan
2016-06-29 9:45 ` tip-bot for Wang Nan [this message]
2016-06-24 11:22 ` [PATCH v2 3/7] perf ctf: Add 'all' option Wang Nan
2016-06-29 9:46 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 4/7] perf ctf: Prepare collect non-sample events Wang Nan
2016-06-29 9:46 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 5/7] perf ctf: Generate comm event to CTF output Wang Nan
2016-06-29 9:46 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 6/7] perf ctf: Add '--all' option for 'perf data convert' Wang Nan
2016-06-29 9:47 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 11:22 ` [PATCH v2 7/7] perf ctf: Generate fork and exit events to CTF output Wang Nan
2016-06-29 9:47 ` [tip:perf/core] perf data " tip-bot for Wang Nan
2016-06-24 12:28 ` [PATCH v2 0/7] perf ctf: Convert comm, fork and exit events to CTF Jiri Olsa
2016-06-27 19:03 ` Arnaldo Carvalho de Melo
2016-06-24 12:29 ` Jiri Olsa
2016-06-24 12:33 ` pi3orama
2016-06-24 12:55 ` Jiri Olsa
2016-06-24 12:41 ` Arnaldo Carvalho de Melo
2016-06-24 12:43 ` pi3orama
2016-06-24 13:08 ` Jiri Olsa
2016-06-24 12:44 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3275f68e50290acd04612c6af41173fe83fdf4b0@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome