From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Suchanek <hramrach@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dan Williams <dan.j.williams@intel.com>,
Tejun Heo <tj@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Dmitry Vyukov <dvyukov@google.com>,
Adrien Schildknecht <adrien+dev@schischi.me>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 3/3] drivers core: allow id match override when manually binding driver
Date: Mon, 27 Jun 2016 12:09:15 -0700 [thread overview]
Message-ID: <20160627190915.GA5111@kroah.com> (raw)
In-Reply-To: <CAOMqctSJjvyknkTjHZbfbt8nh0Eo_oc9LTonjZGUmwP5b8gWDg@mail.gmail.com>
On Sun, Jun 26, 2016 at 09:07:08PM +0200, Michal Suchanek wrote:
> On 26 June 2016 at 20:28, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jun 23, 2016 at 05:41:20PM -0000, Michal Suchanek wrote:
> >> This allows binding spidev on any slave device by hand using sysfs
> >> without adding superfluous compatibles or any other needless
> >> complication.
> >>
> >> Note that any slave driver that requires configuration will fail to
> >> probe anyway. Only a driver that binds to anything can be bound
> >> successfully.
> >>
> >> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> >> ---
> >> drivers/base/Kconfig.debug | 14 +++++++++
> >> drivers/base/bus.c | 72 +++++++++++++++++++++++++++++++++++++++++++++-
> >> lib/Kconfig.debug | 2 ++
> >> 3 files changed, 87 insertions(+), 1 deletion(-)
> >> create mode 100644 drivers/base/Kconfig.debug
> >>
> >> diff --git a/drivers/base/Kconfig.debug b/drivers/base/Kconfig.debug
> >> new file mode 100644
> >> index 0000000..e21d3cc
> >> --- /dev/null
> >> +++ b/drivers/base/Kconfig.debug
> >> @@ -0,0 +1,14 @@
> >> +menuconfig DRIVER_MATCH_OVERRIDE
> >> + bool "Allow manual driver binding to override id match (DANGEROUS)"
> >> + default n
> >> + help
> >> + When binding a driver manually bypass the check of driver id table
> >> + against device id in driver core. This can be useful for development
> >> + or on buses that don't provide reliable device identification.
> >
> > Ick, no no no. Why would you ever want to let this happen? If you
> > really want to override the check, just write things to the 'bind' file
> > in sysfs, that will skip the driver id check entirely, right?
>
> Well, it does not. Hence this patch which enables skipping the check.
> It's the whole point of it.
Then write the id you wish to use for that driver to the new_id file for
that driver. Doesn't that work?
thanks,
greg k-h
prev parent reply other threads:[~2016-06-27 19:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 14:20 [PATCH 0/3] Another stab at making spidev usable with devicetree Michal Suchanek
2016-06-24 14:20 ` [PATCH 1/3] spi: spidev: fix the check for spidev in dt Michal Suchanek
2016-06-26 1:09 ` Mark Brown
2016-06-26 1:56 ` Michal Suchanek
2016-06-26 1:13 ` Mark Brown
2016-06-26 2:12 ` Michal Suchanek
2016-06-26 11:05 ` Mark Brown
2016-06-24 14:20 ` [PATCH 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek
2016-06-26 1:15 ` Mark Brown
2016-06-26 2:23 ` Michal Suchanek
2016-06-26 11:21 ` Mark Brown
2016-06-26 11:35 ` Michal Suchanek
2016-06-26 11:58 ` Mark Brown
2016-06-26 12:39 ` Michal Suchanek
2016-06-26 12:45 ` Mark Brown
2016-06-26 12:53 ` Michal Suchanek
2016-06-26 12:57 ` Mark Brown
2016-06-26 15:19 ` Michal Suchanek
2016-06-26 17:25 ` Mark Brown
2016-06-24 14:20 ` [PATCH 3/3] drivers core: allow id match override when manually binding driver Michal Suchanek
2016-06-26 1:17 ` Mark Brown
2016-06-26 4:14 ` Dan Williams
2016-06-26 6:44 ` Michal Suchanek
2016-06-26 9:26 ` Geert Uytterhoeven
2016-06-26 18:28 ` Greg Kroah-Hartman
2016-06-26 19:07 ` Michal Suchanek
2016-06-27 19:09 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627190915.GA5111@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrien+dev@schischi.me \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=dvyukov@google.com \
--cc=hramrach@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome