From: Mark Brown <broonie@kernel.org>
To: Michal Suchanek <hramrach@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dan Williams <dan.j.williams@intel.com>,
Tejun Heo <tj@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Dmitry Vyukov <dvyukov@google.com>,
Adrien Schildknecht <adrien+dev@schischi.me>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver
Date: Sun, 26 Jun 2016 02:15:00 +0100 [thread overview]
Message-ID: <20160626011500.GF28202@sirena.org.uk> (raw)
In-Reply-To: <ebe2a48124441819adab773b28cd12425ba5bda4.1466696079.git.hramrach@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On Thu, Jun 23, 2016 at 05:41:20PM -0000, Michal Suchanek wrote:
> SPI slave devices are not created when looking up driver for the slave
> fails. Create a device anyway so it can be manually bound to a driver.
> @@ -1543,11 +1542,10 @@ of_register_spi_device(struct spi_master *master, struct device_node *nc)
> /* Device speed */
> rc = of_property_read_u32(nc, "spi-max-frequency", &value);
> if (rc) {
> - dev_err(&master->dev, "%s has no valid 'spi-max-frequency' property (%d)\n",
> + dev_warn(&master->dev, "%s has no valid 'spi-max-frequency' property (%d)\n",
> nc->full_name, rc);
> - goto err_out;
> - }
> - spi->max_speed_hz = value;
> + } else
> + spi->max_speed_hz = value;
>
I can't relate this hunk to the changelog and there's a coding style
problem, if there's { } on one side of an if statement it should be on
both sides. Why are we making this change?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-26 1:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 14:20 [PATCH 0/3] Another stab at making spidev usable with devicetree Michal Suchanek
2016-06-24 14:20 ` [PATCH 1/3] spi: spidev: fix the check for spidev in dt Michal Suchanek
2016-06-26 1:09 ` Mark Brown
2016-06-26 1:56 ` Michal Suchanek
2016-06-26 1:13 ` Mark Brown
2016-06-26 2:12 ` Michal Suchanek
2016-06-26 11:05 ` Mark Brown
2016-06-24 14:20 ` [PATCH 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek
2016-06-26 1:15 ` Mark Brown [this message]
2016-06-26 2:23 ` Michal Suchanek
2016-06-26 11:21 ` Mark Brown
2016-06-26 11:35 ` Michal Suchanek
2016-06-26 11:58 ` Mark Brown
2016-06-26 12:39 ` Michal Suchanek
2016-06-26 12:45 ` Mark Brown
2016-06-26 12:53 ` Michal Suchanek
2016-06-26 12:57 ` Mark Brown
2016-06-26 15:19 ` Michal Suchanek
2016-06-26 17:25 ` Mark Brown
2016-06-24 14:20 ` [PATCH 3/3] drivers core: allow id match override when manually binding driver Michal Suchanek
2016-06-26 1:17 ` Mark Brown
2016-06-26 4:14 ` Dan Williams
2016-06-26 6:44 ` Michal Suchanek
2016-06-26 9:26 ` Geert Uytterhoeven
2016-06-26 18:28 ` Greg Kroah-Hartman
2016-06-26 19:07 ` Michal Suchanek
2016-06-27 19:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626011500.GF28202@sirena.org.uk \
--to=broonie@kernel.org \
--cc=adrien+dev@schischi.me \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hramrach@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome