From: Steven Rostedt <rostedt@goodmis.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Jiri Olsa <jolsa@kernel.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
lkml <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [RFC/PATCH] lib/vsprintf: Add support to store cpumask
Date: Tue, 28 Jun 2016 18:05:40 -0400 [thread overview]
Message-ID: <20160628180540.5da4405e@gandalf.local.home> (raw)
In-Reply-To: <87mvm5gezg.fsf@rasmusvillemoes.dk>
On Tue, 28 Jun 2016 23:50:27 +0200
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> On Tue, Jun 28 2016, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > But people don't usually run "make smatch" on debug kernels.
> > trace_printk() currently is not allowed to be used in the kernel. When
> > it is used, a big ugly banner is posted on boot up saying that the
> > kernel is in "debug mode" and is "unstable" (even though it isn't) just
> > to scare people enough to never compile with a trace_printk() in their
> > code. If they need a permanent trace_printk() then they need to use
> > tracepoints.
>
> But don't tracepoints also pass through vbin_printf? IOW, are there no
> print-like function calls in the kernel where a static checker warning
> for %pX would be worthwhile?
tracepoints don't use vbin_printf() but you are right, they do save the
data in binary format parse them out later.
Perhaps we should set up something in the static checker to test for
this in TP_printk() within the TRACE_EVENT() macros.
-- Steve
next prev parent reply other threads:[~2016-06-28 22:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 15:34 Jiri Olsa
2016-06-28 16:26 ` Steven Rostedt
2016-06-28 19:27 ` Rasmus Villemoes
2016-06-28 19:56 ` Steven Rostedt
2016-06-28 21:50 ` Rasmus Villemoes
2016-06-28 22:05 ` Steven Rostedt [this message]
2016-06-28 22:06 ` Steven Rostedt
2016-06-29 6:43 ` Jiri Olsa
2016-06-29 15:42 ` Steven Rostedt
2016-06-28 21:19 ` Rasmus Villemoes
2016-06-29 7:12 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628180540.5da4405e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®