mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: Dept-GELinuxNICDev@qlogic.com, sony.chacko@qlogic.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag()
Date: Wed, 29 Jun 2016 05:48:01 -0400 (EDT)	[thread overview]
Message-ID: <20160629.054801.713412217544385924.davem@davemloft.net> (raw)
In-Reply-To: <20160627205029.GA22095@mwanda>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 27 Jun 2016 23:50:29 +0300

> There is a static checker warning here "warn: mask and shift to zero"
> and the code sets "ring" to zero every time.  From looking at how
> QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the
> qlcnic_83xx_hndl() should be removed.
> 
> Fixes: 4be41e92f7c6 ('qlcnic: 83xx data path routines')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

      reply	other threads:[~2016-06-29  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 20:50 Dan Carpenter
2016-06-29  9:48 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160629.054801.713412217544385924.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Dept-GELinuxNICDev@qlogic.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sony.chacko@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®