From: Wolfram Sang <wsa@the-dreams.de>
To: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Cc: Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr,
nicolas.palix@imag.fr, mmarek@suse.com, cocci@systeme.lip6.fr,
linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource
Date: Wed, 29 Jun 2016 21:23:57 +0200 [thread overview]
Message-ID: <20160629192357.GA9260@tetsubishi> (raw)
In-Reply-To: <20160629183347.GA17067@amitoj-Inspiron-3542>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote:
> This script detects cases which have incorrect error handling for
> devm_ioremap_resource function, employing a NULL test instead of an
> IS_ERR() test.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Why don't we fix the code at the same time?
And it should not be restricted to devm_ioremap_resource() but
extensible so other functions could be added later?
(Surprised to see that we don't have such a script yet)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-29 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 18:33 Amitoj Kaur Chawla
2016-06-29 19:23 ` Wolfram Sang [this message]
2016-06-30 2:43 ` [Cocci] " Amitoj Kaur Chawla
2016-06-30 7:14 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629192357.GA9260@tetsubishi \
--to=wsa@the-dreams.de \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=amitoj1606@gmail.com \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®