mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	acme@redhat.com, mingo@kernel.org, jolsa@redhat.com,
	vincent.weaver@maine.edu, eranian@google.com,
	alexander.shishkin@linux.intel.com, hpa@zytor.com,
	kan.liang@intel.com, torvalds@linux-foundation.org,
	davidcc@google.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86/intel: Add {rd,wr}lbr_{to,from} wrappers
Date: Wed, 29 Jun 2016 21:32:44 +0200	[thread overview]
Message-ID: <20160629193244.GZ30921@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <tip-d4cf1949f9689314aef962eea95df84a8288d097@git.kernel.org>

On Mon, Jun 27, 2016 at 05:56:02AM -0700, tip-bot for Peter Zijlstra wrote:
> +static inline u64 rdlbr_from(unsigned int idx)
> +{
> +	u64 val;
> +
> +	rdmsrl(x86_pmu.lbr_from + idx, val);
> +
> +	return lbr_from_signext_quirk_rd(val);
> +}
> +
> +static inline u64 rdlbr_to(unsigned int idx)
> +{
> +	u64 val;
> +
> +	rdmsrl(x86_pmu.lbr_from + idx, val);

Things work loads better when we use:

	rdmsrl(x86_pmu.lbr_to + idx, val);

:-/

> +
>  	return val;
>  }

           reply	other threads:[~2016-06-29 19:34 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <tip-d4cf1949f9689314aef962eea95df84a8288d097@git.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160629193244.GZ30921@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=davidcc@google.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®