mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	<linux-clk@vger.kernel.org>
Subject: [PATCH 05/10] clk: oxnas: make it explicitly non-modular
Date: Mon, 4 Jul 2016 17:12:15 -0400	[thread overview]
Message-ID: <20160704211220.5685-6-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160704211220.5685-1-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/clk/Kconfig:config COMMON_CLK_OXNAS
drivers/clk/Kconfig:    bool "Clock driver for the OXNAS SoC Family"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-clk@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/clk/clk-oxnas.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c
index 79bcb2e42060..47649ac5d399 100644
--- a/drivers/clk/clk-oxnas.c
+++ b/drivers/clk/clk-oxnas.c
@@ -18,7 +18,7 @@
 
 #include <linux/clk-provider.h>
 #include <linux/kernel.h>
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/stringify.h>
@@ -170,26 +170,17 @@ static int oxnas_stdclk_probe(struct platform_device *pdev)
 				   clk_oxnas->onecell_data);
 }
 
-static int oxnas_stdclk_remove(struct platform_device *pdev)
-{
-	of_clk_del_provider(pdev->dev.of_node);
-
-	return 0;
-}
-
 static const struct of_device_id oxnas_stdclk_dt_ids[] = {
 	{ .compatible = "oxsemi,ox810se-stdclk" },
 	{ }
 };
-MODULE_DEVICE_TABLE(of, oxnas_stdclk_dt_ids);
 
 static struct platform_driver oxnas_stdclk_driver = {
 	.probe = oxnas_stdclk_probe,
-	.remove = oxnas_stdclk_remove,
 	.driver	= {
 		.name = "oxnas-stdclk",
+		.suppress_bind_attrs = true,
 		.of_match_table = oxnas_stdclk_dt_ids,
 	},
 };
-
-module_platform_driver(oxnas_stdclk_driver);
+builtin_platform_driver(oxnas_stdclk_driver);
-- 
2.8.4

  parent reply	other threads:[~2016-07-04 21:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 21:12 [PATCH 00/10] clk: fix/remove module usage in non-modular code Paul Gortmaker
2016-07-04 21:12 ` [PATCH 01/10] clk: meson8b: make it explicitly non-modular Paul Gortmaker
2016-07-06 22:21   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 02/10] clk: meson: make gxbb " Paul Gortmaker
2016-07-06 22:21   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 03/10] clk: mvebu: make cp110-system-controller " Paul Gortmaker
2016-11-04 20:32   ` Stephen Boyd
2016-07-04 21:12 ` [PATCH 04/10] clk: mvebu: make ap806-system-controller " Paul Gortmaker
2016-11-04 20:33   ` Stephen Boyd
2016-07-04 21:12 ` Paul Gortmaker [this message]
2016-07-06 13:11   ` [PATCH 05/10] clk: oxnas: make it " Neil Armstrong
2016-07-06 22:21   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 06/10] clk: samsung make clk-exynos-audss " Paul Gortmaker
2016-07-05  9:04   ` Krzysztof Kozlowski
2016-07-05 13:32     ` Paul Gortmaker
2016-07-05 11:02   ` Geert Uytterhoeven
2016-07-05 13:17     ` Paul Gortmaker
2016-07-07 13:12   ` Sylwester Nawrocki
2016-07-04 21:12 ` [PATCH 07/10] clk: samsung: make clk-s5pv210-audss " Paul Gortmaker
2016-07-06 10:49   ` Sylwester Nawrocki
2016-07-13 10:32   ` Sylwester Nawrocki
2016-07-13 21:59     ` Michael Turquette
2016-07-04 21:12 ` [PATCH 08/10] clk: sunxi: make clk-* " Paul Gortmaker
2016-07-04 21:36   ` Boris Brezillon
2016-07-05  6:13   ` Maxime Ripard
2016-07-06 22:22   ` Michael Turquette
2016-07-04 21:12 ` [PATCH 09/10] clk: tegra: make clk-tegra124-dfll-fcpu " Paul Gortmaker
2016-11-04 20:33   ` Stephen Boyd
2016-07-04 21:12 ` [PATCH 10/10] clk: ti: make clk-dra7-atl " Paul Gortmaker
2016-11-04 20:35   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704211220.5685-6-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=narmstrong@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome