From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"
Date: Thu, 7 Jul 2016 11:37:51 -0400 [thread overview]
Message-ID: <20160707153750.GB11480@localhost.localdomain> (raw)
In-Reply-To: <7732540a-aa37-9e33-e805-838dc4c43676@citrix.com>
On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> On 07/07/16 10:45, Roger Pau Monne wrote:
> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> The functions such get passed to have been taking pointers to const
> >> since at least 2.6.16.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> >
> > Although the wording in the commit message looks weird to me, but I'm not a
> > native speaker anyway.
>
> As a native speaker, I can't parse it either.
>
> I think s/such/these/ is needed.
The functions such as these have been taking pointers to const
since at least 2.6.16.
?
>
> ~Andrew
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-07 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:38 Jan Beulich
2016-07-07 9:45 ` Roger Pau Monne
2016-07-07 9:52 ` [Xen-devel] " Andrew Cooper
2016-07-07 15:37 ` Konrad Rzeszutek Wilk [this message]
2016-07-07 15:57 ` Jan Beulich
2016-07-08 13:55 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707153750.GB11480@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®