From: Steven Rostedt <rostedt@goodmis.org>
To: Laura Abbott <labbott@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] ftrace/scripts: Work around for addition of metag magic but not relocations
Date: Fri, 8 Jul 2016 17:32:37 -0400 [thread overview]
Message-ID: <20160708173237.6a24ef21@gandalf.local.home> (raw)
In-Reply-To: <1468005530-14757-1-git-send-email-labbott@redhat.com>
On Fri, 8 Jul 2016 12:18:50 -0700
Laura Abbott <labbott@redhat.com> wrote:
> glibc recently did a sync up (94e73c95d9b5 "elf.h: Sync with the gabi
> webpage") that added a #define for EM_METAG but did not add relocations
>
> This triggers build errors:
>
> scripts/recordmcount.c: In function 'do_file':
> scripts/recordmcount.c:466:28: error: 'R_METAG_ADDR32' undeclared (first use in this function)
> case EM_METAG: reltype = R_METAG_ADDR32;
> ^~~~~~~~~~~~~~
> scripts/recordmcount.c:466:28: note: each undeclared identifier is reported only once for each function it appears in
> scripts/recordmcount.c:468:20: error: 'R_METAG_NONE' undeclared (first use in this function)
> rel_type_nop = R_METAG_NONE;
> ^~~~~~~~~~~~
>
> Work around this change with some more #ifdefery for the relocations.
Looks fine to me. I'll pull it in, and this probably should go stable
too.
-- Steve
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> I hit this while testing with a newer glibc. I'm not sure what the policy is
> about glibc, so this might just serve as an FYI for anyone else who
> is working on the bleeding edge.
>
> Fedora bug is at https://bugzilla.redhat.com/show_bug.cgi?id=1354034 for the
> curious.
> ---
prev parent reply other threads:[~2016-07-08 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 19:18 Laura Abbott
2016-07-08 21:32 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708173237.6a24ef21@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®