From: Borislav Petkov <bp@alien8.de>
To: Dave Young <dyoung@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, "Franck Bui" <fbui@suse.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg
Date: Mon, 18 Jul 2016 11:06:32 +0200 [thread overview]
Message-ID: <20160718090632.GD22689@nazgul.tnic> (raw)
In-Reply-To: <20160718081712.GA9239@dhcp-128-65.nay.redhat.com>
On Mon, Jul 18, 2016 at 04:17:12PM +0800, Dave Young wrote:
> Because IMHO it is wrong, they can not be ratelimited because the writing could
> be from different userspace programs.
It is ratelimited by interface openers.
> Simply ratelimiting different sources of writing is pointless to me.
So what are you arguing for? What is the *actual* *real-life* *use* case
you think will be handicapped?
> One can only see messages they would like to see by luck, it is worse
> than off.
THAT'S WHY YOU BOOT WITH "printk.devkmsg=on" TO SEE THEM ALL!
The /dev/kmsg thing was added for the more or less, wrong, historic
reasons and userspace started abusing it and interfering with kernel
operation. That's why we're adding this tristate option.
In the default case we're ratelimiting writes to it because they should
not interfere with kernel operation.
[ Frankly, those writes are pretty much useless to the normal user so
we can just as well ignore them but WTH. ]
So give me a concrete problem you see with the ralimiting and not some
notion of a feeling you might have of it being pointless, ok?
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2016-07-18 9:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:18 [PATCH -v4 0/2] printk.devkmsg: Ratelimit it by default Borislav Petkov
2016-07-08 9:18 ` [PATCH -v4 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov
2016-07-14 20:29 ` Andrew Morton
2016-07-15 4:00 ` Borislav Petkov
2016-07-08 9:18 ` [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov
2016-07-14 20:23 ` Andrew Morton
2016-07-14 20:39 ` Steven Rostedt
2016-07-15 4:29 ` Borislav Petkov
2016-07-15 6:21 ` Dave Young
2016-07-15 12:45 ` Borislav Petkov
2016-07-16 10:44 ` Dave Young
2016-07-17 5:40 ` Borislav Petkov
2016-07-18 2:18 ` Dave Young
2016-07-18 4:44 ` Borislav Petkov
2016-07-18 5:20 ` Dave Young
2016-07-18 7:21 ` Borislav Petkov
2016-07-18 7:38 ` Dave Young
2016-07-18 8:08 ` Borislav Petkov
2016-07-18 8:17 ` Dave Young
2016-07-18 9:06 ` Borislav Petkov [this message]
2016-07-19 0:35 ` Dave Young
2016-07-19 6:49 ` Borislav Petkov
2016-07-19 7:02 ` Dave Young
2016-07-25 15:18 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718090632.GD22689@nazgul.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=fbui@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome