From: Mark Brown <broonie@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
Andy Green <andy@warmcat.com>, Andy Green <andy.green@linaro.org>
Subject: Re: [RFC][PATCH 09/10 v2] ASoC: hisilicon: Add hi6210 hdmi codec driver
Date: Wed, 20 Jul 2016 01:31:42 +0100 [thread overview]
Message-ID: <20160720003142.GD6509@sirena.org.uk> (raw)
In-Reply-To: <1468970566-24498-10-git-send-email-john.stultz@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
On Tue, Jul 19, 2016 at 04:22:45PM -0700, John Stultz wrote:
> Add codec driver for hi6210 hdmi audio output on hi6220 boards.
>
> This seems like a lot of code just to fill and register a
> snd_soc_dai_driver to 2 channel, 16bits, 48k. I suspect there's
> a better way.
This appears to be open coding HDMI support without any integration with
the video side of HDMI (which we have helpers for, see hdmi-codec.c.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-20 0:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 23:22 [RFC][PATCH 00/10 v2] Add HDMI audio support for HiKey John Stultz
2016-07-19 23:22 ` [RFC][PATCH 01/10 v2] k3dma: Fix hisi burst clipping John Stultz
2016-07-19 23:22 ` [RFC][PATCH 02/10 v2] k3dma: Fix dma err offsets John Stultz
2016-07-19 23:22 ` [RFC][PATCH 03/10 v2] k3dma: Fix "nobody cared" message seen on any error John Stultz
2016-07-19 23:22 ` [RFC][PATCH 04/10 v2] k3dma: Add cyclic mode for audio John Stultz
2016-07-19 23:22 ` [RFC][PATCH 05/10 v2] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms John Stultz
2016-07-19 23:22 ` [RFC][PATCH 06/10 v2] ASoC: add hi6210-i2s DT bindings John Stultz
2016-07-19 23:22 ` [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio driver John Stultz
2016-07-20 0:28 ` Mark Brown
2016-07-20 16:53 ` John Stultz
2016-07-20 17:08 ` Mark Brown
2016-07-19 23:22 ` [RFC][PATCH 08/10 v2] ASoC: add hi6210-hdmi-audio-codec DT bindings John Stultz
2016-07-19 23:22 ` [RFC][PATCH 09/10 v2] ASoC: hisilicon: Add hi6210 hdmi codec driver John Stultz
2016-07-20 0:31 ` Mark Brown [this message]
2016-07-19 23:22 ` [RFC][PATCH 10/10 v2] dts: hi6220: Add k3-dma and i2s/hdmi audio support John Stultz
2016-07-20 0:22 ` [RFC][PATCH 00/10 v2] Add HDMI audio support for HiKey Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720003142.GD6509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.green@linaro.org \
--cc=andy@warmcat.com \
--cc=dan.j.williams@intel.com \
--cc=jg1.han@samsung.com \
--cc=john.stultz@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®