From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on UP
Date: Thu, 21 Jul 2016 08:15:24 +0900 [thread overview]
Message-ID: <20160720231523.GD9599@verge.net.au> (raw)
In-Reply-To: <CAMuHMdWJOVs_pzDHWVHN8=mguUPETbq2m8LAG_N6mUFk+UA_og@mail.gmail.com>
On Thu, Jun 30, 2016 at 03:09:46PM +0200, Geert Uytterhoeven wrote:
> Hi Arnd,
>
> On Thu, Jun 30, 2016 at 2:25 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > For rcar-gen2, we build the SMP files even for UP configurations,
> > and that just broke:
> >
> > arch/arm/mach-shmobile/built-in.o: In function `shmobile_smp_init_fallback_ops':
> > pm-rcar-gen2.c:(.init.text+0x40c): undefined reference to `platform_can_secondary_boot'
> >
> > This adds an compile-time check before the call to platform_can_secondary_boot,
> > turning the function into an empty stub for UP configurations.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: c21af444eace ("ARM: shmobile: smp: Add function to prioritize DT SMP")
>
> Crap, I think I took the shortcut of only compile-testing
> arch/arm/mach-shmobile,
> not link-testing the whole kernel, with CONFIG_SMP=n...
>
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Sorry for missing this until now.
I have queued it up as a fix for v4.7.
prev parent reply other threads:[~2016-07-20 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 12:25 Arnd Bergmann
2016-06-30 13:09 ` Geert Uytterhoeven
2016-07-20 23:15 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720231523.GD9599@verge.net.au \
--to=horms@verge.net.au \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®