mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andi Shyti <andi@etezian.org>
Subject: Re: [RFC 3/7] [media] rc-core: add support for IR raw transmitters
Date: Thu, 21 Jul 2016 09:44:14 +0900	[thread overview]
Message-ID: <20160721004414.GE23521@samsunx.samsung> (raw)
In-Reply-To: <20160719221027.GB24697@gofer.mess.org>

Hi Sean,

> > +	if (dev->driver_type == RC_DRIVER_IR_RAW ||
> > +				dev->driver_type == RC_DRIVER_IR_RAW_TX) {
> 
> Here the if is wrong. It should be 
> "if (dev->driver_type != RC_DRIVER_IR_RAW_TX)". Note that as result
> the decoder thread is not started, so patch 4 won't be needed either.

but I need the ir-lirc-codec as it handles the interface with
userspace and it calls the tx_ir and s_tx_carrier.

if I do "if (dev->driver_type != RC_DRIVER_IR_RAW_TX)" the
lirc-codec is not called and I would need to handle it on my
driver, but then we fall in the first version of the driver.

Thanks,
Andi

> >  		if (!raw_init) {
> >  			request_module_nowait("ir-lirc-codec");
> >  			raw_init = true;

  reply	other threads:[~2016-07-21  0:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 15:56 [RFC 0/7] Add support for IR transmitters Andi Shyti
2016-07-19 15:56 ` [RFC 1/7] [media] rc-main: assign driver type during allocation Andi Shyti
2016-07-19 22:04   ` Sean Young
2016-07-21  0:19     ` Andi Shyti
2016-07-19 15:56 ` [RFC 2/7] [media] rc-main: split setup and unregister functions Andi Shyti
2016-07-19 15:56 ` [RFC 3/7] [media] rc-core: add support for IR raw transmitters Andi Shyti
2016-07-19 22:10   ` Sean Young
2016-07-21  0:44     ` Andi Shyti [this message]
2016-07-19 15:56 ` [RFC 4/7] [media] rc-ir-raw: do not generate any receiving thread for " Andi Shyti
2016-07-19 15:56 ` [RFC 5/7] [media] ir-lirc-codec: do not handle any buffer " Andi Shyti
2016-07-19 22:16   ` Sean Young
2016-07-21  0:48     ` Andi Shyti
2016-07-21 14:43       ` Sean Young
2016-07-19 15:56 ` [RFC 6/7] Documentation: bindings: add documentation for ir-spi device driver Andi Shyti
2016-07-19 15:56 ` [RFC 7/7] [media] rc: add support for IR LEDs driven through SPI Andi Shyti
2016-07-19 23:11   ` Sean Young
2016-07-21  1:09     ` Andi Shyti
2016-07-21 10:22       ` Sean Young
2016-07-21 14:57         ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160721004414.GE23521@samsunx.samsung \
    --to=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®